error: missing documentation for a module --> halo2_gadgets/src/utilities_opt.rs:3:1 | 3 | pub mod cond_swap; | ^^^^^^^^^^^^^^^^^

error: missing documentation for a function --> halo2_gadgets/src/utilities/lookup_range_check.rs:30:1 | 30 | / pub fn witness_short_generic<F, C, const K: usize>( 31 | | lookup_config: &C, 32 | | layouter: impl Layouter<F>, 33 | | value: Value<&F>, ... | 37 | | F: PrimeFieldBits, 38 | | C: LookupRangeCheck<F, K>, | |______________________________^

error: missing documentation for a method --> halo2_gadgets/src/utilities/cond_swap.rs:31:5 | 31 | / fn mux( 32 | | &self, 33 | | layouter: &mut impl Layouter<F>, 34 | | choice: Self::Var, 35 | | left: Self::Var, 36 | | right: Self::Var, 37 | | ) -> Result<Self::Var, Error>; | |__________________________________^

error: missing documentation for a module --> halo2_gadgets/src/sinsemilla_opt.rs:1:1 | 1 | pub mod chip; | ^^^^^^^^^^^^

error: missing documentation for a function --> halo2_gadgets/src/sinsemilla/chip.rs:329:1 | 329 | / pub fn create_common_config<Hash, Commit, F>( 330 | | meta: &mut ConstraintSystem<pallas::Base>, 331 | | advices: [Column<Advice>; 5], 332 | | witness_pieces: Column<Advice>, ... | 337 | | F: FixedPoints<pallas::Affine>, 338 | | Commit: CommitDomains<pallas::Affine, F, Hash>, | |___________________________________________________^

error: missing documentation for an associated function --> halo2_gadgets/src/sinsemilla/chip.rs:249:5 | 249 | / fn configure( 250 | | meta: &mut ConstraintSystem<pallas::Base>, 251 | | advices: [Column<Advice>; 5], 252 | | witness_pieces: Column<Advice>, ... | 255 | | range_check: Self::RangeCheckConfigType, 256 | | ) -> Self::SinsemillaConfigType; | |____________________________________^

error: missing documentation for a method --> halo2_gadgets/src/sinsemilla/chip.rs:239:5 | 239 | fn base(&self) -> &SinsemillaConfigCommon<Hash, Commit, F>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for an associated type --> halo2_gadgets/src/sinsemilla/chip.rs:237:5 | 237 | type LookupType; | ^^^^^^^^^^^^^^^

error: missing documentation for an associated type --> halo2_gadgets/src/sinsemilla/chip.rs:236:5 | 236 | type SinsemillaConfigType: SinsemillaConfigProps<Hash, Commit, F>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for an associated type --> halo2_gadgets/src/sinsemilla/chip.rs:235:5 | 235 | type RangeCheckConfigType; | ^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for an associated type --> halo2_gadgets/src/sinsemilla/chip.rs:233:5 | 233 | type Loaded; | ^^^^^^^^^^^

error: missing documentation for a trait --> halo2_gadgets/src/sinsemilla/chip.rs:227:1 | 227 | pub trait SinsemillaChipProps<Hash, Commit, F> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for a method --> halo2_gadgets/src/sinsemilla/chip.rs:114:5 | 114 | fn configure_from_y_q(&self, meta: &mut ConstraintSystem<pallas::Base>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for a method --> halo2_gadgets/src/sinsemilla/chip.rs:112:5 | 112 | fn get_y_q(&self, meta: &mut VirtualCells<pallas::Base>) -> Expression<pallas::Base>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for a method --> halo2_gadgets/src/sinsemilla/chip.rs:89:5 | 89 | fn base(&self) -> &SinsemillaConfigCommon<Hash, Commit, F>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for an associated type --> halo2_gadgets/src/sinsemilla/chip.rs:88:5 | 88 | type LookupConfigType; | ^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for a trait --> halo2_gadgets/src/sinsemilla/chip.rs:82:1 | 82 | pub trait SinsemillaConfigProps<Hash, Commit, F> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for a module --> halo2_gadgets/src/lib.rs:30:1 | 30 | pub mod sinsemilla_opt; | ^^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> halo2_gadgets/src/lib.rs:21:9 | 21 | #![deny(missing_docs)] | ^^^^^^^^^^^^

missing documentation for a module

missing documentation for a trait

missing documentation for an associated type

missing documentation for a method

missing documentation for a method

missing documentation for a method

missing documentation for a trait

missing documentation for an associated type

missing documentation for an associated type

missing documentation for an associated type

failed to resolve: use of undeclared crate or module `proptest`

Compilation failed, aborting rustdoc

could not document `halo2_gadgets`

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

failed to resolve: use of undeclared crate or module `proptest`

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

failed to resolve: use of undeclared crate or module `proptest`

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

The job was canceled because "wasm32-wasi" failed.

The operation was canceled.

missing documentation for a trait

missing documentation for an associated type

missing documentation for an associated function

missing documentation for an associated function

missing documentation for an associated function

missing documentation for a trait

missing documentation for an associated type

missing documentation for an associated type

missing documentation for an associated type

missing documentation for an associated type

The job was canceled because "stable_ubuntu-latest" failed.

missing documentation for a trait

missing documentation for an associated type

missing documentation for an associated function

missing documentation for an associated function

missing documentation for an associated function

missing documentation for a trait

missing documentation for an associated type

missing documentation for an associated type

missing documentation for an associated type

missing documentation for an associated type

The job was canceled because "stable_ubuntu-latest" failed.

The operation was canceled.

The job was canceled because "stable_ubuntu-latest" failed.

The job was canceled because "stable_ubuntu-latest" failed.

The operation was canceled.

The operation was canceled.

The job was canceled because "stable_ubuntu-latest" failed.

The operation was canceled.

The job was canceled because "stable_ubuntu-latest" failed.

The operation was canceled.

The job was canceled because "stable_ubuntu-latest" failed.

The operation was canceled.

The job was canceled because "stable_ubuntu-latest" failed.

missing documentation for a trait

missing documentation for an associated type

missing documentation for an associated function

missing documentation for an associated function

missing documentation for an associated function

missing documentation for a trait

missing documentation for an associated type

missing documentation for an associated type

missing documentation for an associated type

missing documentation for an associated type

Process completed with exit code 101.

The job was canceled because "stable" failed.

The operation was canceled.

The job was canceled because "stable" failed.

The operation was canceled.

The process '/home/runner/.cargo/bin/cargo' failed with exit code 1

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

warning: variable `Y_A_next` should have a snake case name --> halo2_gadgets/src/sinsemilla/chip.rs:162:17 | 162 | let Y_A_next = Y_A(meta, Rotation::next()); | ^^^^^^^^ help: convert the identifier to snake case: `y_a_next`

warning: variable `Y_A_cur` should have a snake case name --> halo2_gadgets/src/sinsemilla/chip.rs:159:17 | 159 | let Y_A_cur = Y_A(meta, Rotation::cur()); | ^^^^^^^ help: convert the identifier to snake case: `y_a_cur`

warning: variable `Y_A_cur` should have a snake case name --> halo2_gadgets/src/sinsemilla/chip.rs:135:17 | 135 | let Y_A_cur = Y_A(meta, Rotation::cur()); | ^^^^^^^ help: convert the identifier to snake case: `y_a_cur`

warning: variable `Y_A` should have a snake case name --> halo2_gadgets/src/sinsemilla/chip.rs:124:13 | 124 | let Y_A = |meta: &mut VirtualCells<pallas::Base>, rotation| { | ^^^ help: convert the identifier to snake case: `y_a` | = note: `#[warn(non_snake_case)]` on by default

warning: an array of `Range` that is only one element --> halo2_gadgets/src/utilities.rs:407:47 | 407 | decompose(pallas::Base::random(rng), &[0..255]); | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init = note: `-W clippy::single-range-in-vec-init` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::single_range_in_vec_init)]` help: if you wanted a `Vec` that contains the entire range, try | 407 | decompose(pallas::Base::random(rng), &(0..255).collect::<std::vec::Vec<usize>>()); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ help: if you wanted an array of len 255, try | 407 | decompose(pallas::Base::random(rng), &[0; 255]); | ~~~~~~

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:127:34 | 127 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:118:34 | 118 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:103:34 | 103 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities/lookup_range_check.rs:52:34 | 52 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_gadgets/src/sinsemilla.rs:759:48 | 759 | ... .chain(right.into_iter()), | ^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `right` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_gadgets/src/sinsemilla.rs:758:48 | 758 | ... .chain(left.into_iter()) | ^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `left` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`

warning: use of `default` to create a unit struct --> halo2_gadgets/src/sinsemilla/primitives.rs:351:31 | 351 | let mut os_rng = OsRng::default(); | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: variable `Y_A_next` should have a snake case name --> halo2_gadgets/src/sinsemilla/chip.rs:162:17 | 162 | let Y_A_next = Y_A(meta, Rotation::next()); | ^^^^^^^^ help: convert the identifier to snake case: `y_a_next`

warning: variable `Y_A_cur` should have a snake case name --> halo2_gadgets/src/sinsemilla/chip.rs:159:17 | 159 | let Y_A_cur = Y_A(meta, Rotation::cur()); | ^^^^^^^ help: convert the identifier to snake case: `y_a_cur`

warning: variable `Y_A_cur` should have a snake case name --> halo2_gadgets/src/sinsemilla/chip.rs:135:17 | 135 | let Y_A_cur = Y_A(meta, Rotation::cur()); | ^^^^^^^ help: convert the identifier to snake case: `y_a_cur`

warning: variable `Y_A` should have a snake case name --> halo2_gadgets/src/sinsemilla/chip.rs:124:13 | 124 | let Y_A = |meta: &mut VirtualCells<pallas::Base>, rotation| { | ^^^ help: convert the identifier to snake case: `y_a` | = note: `#[warn(non_snake_case)]` on by default

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:127:34 | 127 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:118:34 | 118 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:103:34 | 103 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities/lookup_range_check.rs:52:34 | 52 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon.rs:206:33 | 206 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon.rs:159:33 | 159 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:363:33 | 363 | _domain: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:257:33 | 257 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:220:33 | 220 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:88:38 | 88 | P128Pow5T3Gen(PhantomData::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives/grain.rs:72:32 | 72 | _field: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:517:77 | 517 | let r_0 = (p[0] + config.round_constants[round + 1][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:477:73 | 477 | let r_0 = (p[0] + config.round_constants[round][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:451:62 | 451 | let r: Value<Vec<F>> = q.map(|q| q.map(|q| q.pow(&config.alpha))).collect(); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:256:58 | 256 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| { | __________________________________________________________^ 257 | | res.and_then(|state| { 258 | | state.full_round( 259 | | &mut region, ... | 264 | | }) 265 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:245:61 | 245 | let state = (0..config.half_partial_rounds).fold(Ok(state), |res, r| { | _____________________________________________________________^ 246 | | res.and_then(|state| { 247 | | state.partial_round( 248 | | &mut region, ... | 253 | | }) 254 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:241:58 | 241 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| { | __________________________________________________________^ 242 | | res.and_then(|state| state.full_round(&mut region, config, r, r)) 243 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `-W clippy::manual-try-fold` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:395:42 | 395 | .map(|k| k * (*H_SCALAR).pow(&[(NUM_WINDOWS - 1) as u64, 0, 0, 0]) - offset_acc); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(NUM_WINDOWS - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:390:37 | 390 | acc + (*TWO_SCALAR).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:373:68 | 373 | let scalar = k.map(|k| (k + *TWO_SCALAR) * (*H_SCALAR).pow(&[w as u64, 0, 0, 0])); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:220:45 | 220 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:217:42 | 217 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:200:53 | 200 | * C::Scalar::from(H as u64).pow(&[idx as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[idx as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:72:53 | 72 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:65:38 | 65 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:52:57 | 52 | * C::Scalar::from(H as u64).pow(&[w as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: method `table_range_check_tag` is never used --> halo2_gadgets/src/utilities_opt/lookup_range_check.rs:162:19 | 35 | impl<F: PrimeFieldBits, const K: usize> LookupRangeCheckConfigOptimized<F, K> { | ----------------------------------------------------------------------------- method in this implementation ... 162 | pub(crate) fn table_range_check_tag(&self) -> TableColumn { | ^^^^^^^^^^^^^^^^^^^^^

warning: methods `hash_message_vanilla` and `public_initialization_vanilla` are never used --> halo2_gadgets/src/sinsemilla_opt/chip/hash_to_point.rs:30:19 | 20 | / impl<Hash, Commit, Fixed> SinsemillaChipOptimized<Hash, Commit, Fixed> 21 | | where 22 | | Hash: HashDomains<pallas::Affine>, 23 | | Fixed: FixedPoints<pallas::Affine>, 24 | | Commit: CommitDomains<pallas::Affine, Fixed, Hash>, | |_______________________________________________________- methods in this implementation ... 30 | pub(crate) fn hash_message_vanilla( | ^^^^^^^^^^^^^^^^^^^^ ... 168 | fn public_initialization_vanilla( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: methods `hash_message` and `public_initialization` are never used --> halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs:64:8 | 20 | / impl<Hash, Commit, Fixed> SinsemillaChip<Hash, Commit, Fixed> 21 | | where 22 | | Hash: HashDomains<pallas::Affine>, 23 | | Fixed: FixedPoints<pallas::Affine>, 24 | | Commit: CommitDomains<pallas::Affine, Fixed, Hash>, | |_______________________________________________________- methods in this implementation ... 64 | fn hash_message( | ^^^^^^^^^^^^ ... 215 | fn public_initialization( | ^^^^^^^^^^^^^^^^^^^^^

warning: struct `Variable` is never constructed --> halo2_gadgets/src/sha256/table16/spread_table.rs:308:20 | 308 | pub struct Variable(Column<Advice>, usize); | ^^^^^^^^ | = note: `Variable` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_proofs/src/dev.rs:1066:30 | 1066 | ... .fold(Ok(()), |acc, res| acc.and(res)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold((), |acc, res| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `-W clippy::manual-try-fold` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`

warning: variable does not need to be mutable --> halo2_gadgets/src/sinsemilla_opt/chip/hash_to_point.rs:196:13 | 196 | let mut x_a: X<pallas::Base> = { | ----^^^ | | | help: remove this `mut`

warning: variable does not need to be mutable --> halo2_gadgets/src/sinsemilla_opt/chip/hash_to_point.rs:182:13 | 182 | let mut y_a: Y<pallas::Base> = { | ----^^^ | | | help: remove this `mut`

warning: variable does not need to be mutable --> halo2_gadgets/src/sinsemilla_opt/chip/hash_to_point.rs:174:13 | 174 | let mut offset = 0; | ----^^^^^^ | | | help: remove this `mut`

warning: variable does not need to be mutable --> halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs:196:13 | 196 | let mut x_a: X<pallas::Base> = { | ----^^^ | | | help: remove this `mut`

warning: variable does not need to be mutable --> halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs:182:13 | 182 | let mut y_a: Y<pallas::Base> = { | ----^^^ | | | help: remove this `mut`

warning: variable does not need to be mutable --> halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs:174:13 | 174 | let mut offset = 0; | ----^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:414:33 | 414 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:371:33 | 371 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:328:33 | 328 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon.rs:206:33 | 206 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon.rs:159:33 | 159 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:363:33 | 363 | _domain: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:257:33 | 257 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:220:33 | 220 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives/grain.rs:72:32 | 72 | _field: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:174:22 | 174 | .zip(inv_denoms.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: this bound is already specified as the supertrait of `ExactSizeIterator` --> halo2_proofs/src/poly.rs:167:26 | 167 | inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls = note: `-W clippy::implied-bounds-in-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::implied_bounds_in_impls)]` help: try removing this bound | 167 - inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, 167 + inv_denoms: impl ExactSizeIterator<Item = F>, |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:159:14 | 159 | .zip(assigned_denominators.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: assigning the result of `Clone::clone()` may be inefficient --> halo2_proofs/src/poly/multiopen.rs:208:17 | 208 | point_index_set = point_idx_set.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `point_index_set.clone_from(point_idx_set)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `-W clippy::assigning-clones` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::assigning_clones)]`

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:517:77 | 517 | let r_0 = (p[0] + config.round_constants[round + 1][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:477:73 | 477 | let r_0 = (p[0] + config.round_constants[round][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:451:62 | 451 | let r: Value<Vec<F>> = q.map(|q| q.map(|q| q.pow(&config.alpha))).collect(); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly/multiopen/prover.rs:105:58 | 105 | let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold( | ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:256:58 | 256 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| { | __________________________________________________________^ 257 | | res.and_then(|state| { 258 | | state.full_round( 259 | | &mut region, ... | 264 | | }) 265 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:245:61 | 245 | let state = (0..config.half_partial_rounds).fold(Ok(state), |res, r| { | _____________________________________________________________^ 246 | | res.and_then(|state| { 247 | | state.partial_round( 248 | | &mut region, ... | 253 | | }) 254 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:241:58 | 241 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| { | __________________________________________________________^ 242 | | res.and_then(|state| state.full_round(&mut region, config, r, r)) 243 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `-W clippy::manual-try-fold` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`

warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:124:36 | 124 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:78:36 | 78 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`

warning: the borrowed expression implements the required traits --> halo2_proofs/src/poly/domain.rs:559:20 | 559 | let xn = x.pow(&[8, 0, 0, 0]); | ^^^^^^^^^^^^^ help: change this to: `[8, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_proofs/src/poly/domain.rs:549:38 | 549 | points.push(domain.omega.pow(&[i, 0, 0, 0])); | ^^^^^^^^^^^^^ help: change this to: `[i, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:395:42 | 395 | .map(|k| k * (*H_SCALAR).pow(&[(NUM_WINDOWS - 1) as u64, 0, 0, 0]) - offset_acc); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(NUM_WINDOWS - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:390:37 | 390 | acc + (*TWO_SCALAR).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:373:68 | 373 | let scalar = k.map(|k| (k + *TWO_SCALAR) * (*H_SCALAR).pow(&[w as u64, 0, 0, 0])); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: unused import: `SinsemillaConfigProps` --> halo2_gadgets/src/utilities/lookup_range_check.rs:11:49 | 11 | use crate::sinsemilla::chip::{SinsemillaConfig, SinsemillaConfigProps}; | ^^^^^^^^^^^^^^^^^^^^^

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:319:25 | 319 | / lookups 320 | | .iter() 321 | | .flat_map(move |p| p.queries(vk, x)) 322 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 319 ~ lookups 320 + .iter() 321 ~ .flat_map(move |p| p.queries(vk, x)), |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:259:25 | 259 | / lookups 260 | | .iter() 261 | | .zip(vk.cs.lookups.iter()) 262 | | .flat_map(move |(p, argument)| { ... | 275 | | }) 276 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 259 ~ lookups 260 + .iter() 261 + .zip(vk.cs.lookups.iter()) 262 + .flat_map(move |(p, argument)| { 263 + p.expressions( 264 + l_0, 265 + l_last, 266 + l_blind, 267 + argument, 268 + theta, 269 + beta, 270 + gamma, 271 + advice_evals, 272 + fixed_evals, 273 + instance_evals, 274 + ) 275 ~ }), |

warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/verifier.rs:206:24 | 206 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:707:24 | 707 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookups.iter().flat_map(move |p| p.open(pk, x))` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/prover.rs:599:20 | 599 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:581:28 | 581 | .chain(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:547:14 | 547 | .zip(lookup_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookup_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:546:14 | 546 | .zip(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:220:45 | 220 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:217:42 | 217 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:200:53 | 200 | * C::Scalar::from(H as u64).pow(&[idx as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[idx as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:72:53 | 72 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:65:38 | 65 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:52:57 | 52 | * C::Scalar::from(H as u64).pow(&[w as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:1261:22 | 1261 | .zip(degrees.into_iter()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `degrees` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: method `table_range_check_tag` is never used --> halo2_gadgets/src/utilities_opt/lookup_range_check.rs:162:19 | 35 | impl<F: PrimeFieldBits, const K: usize> LookupRangeCheckConfigOptimized<F, K> { | ----------------------------------------------------------------------------- method in this implementation ... 162 | pub(crate) fn table_range_check_tag(&self) -> TableColumn { | ^^^^^^^^^^^^^^^^^^^^^

warning: methods `hash_message_vanilla` and `public_initialization_vanilla` are never used --> halo2_gadgets/src/sinsemilla_opt/chip/hash_to_point.rs:30:19 | 20 | / impl<Hash, Commit, Fixed> SinsemillaChipOptimized<Hash, Commit, Fixed> 21 | | where 22 | | Hash: HashDomains<pallas::Affine>, 23 | | Fixed: FixedPoints<pallas::Affine>, 24 | | Commit: CommitDomains<pallas::Affine, Fixed, Hash>, | |_______________________________________________________- methods in this implementation ... 30 | pub(crate) fn hash_message_vanilla( | ^^^^^^^^^^^^^^^^^^^^ ... 168 | fn public_initialization_vanilla( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: methods `hash_message` and `public_initialization` are never used --> halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs:64:8 | 20 | / impl<Hash, Commit, Fixed> SinsemillaChip<Hash, Commit, Fixed> 21 | | where 22 | | Hash: HashDomains<pallas::Affine>, 23 | | Fixed: FixedPoints<pallas::Affine>, 24 | | Commit: CommitDomains<pallas::Affine, Fixed, Hash>, | |_______________________________________________________- methods in this implementation ... 64 | fn hash_message( | ^^^^^^^^^^^^ ... 215 | fn public_initialization( | ^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:893:18 | 893 | .zip(self.constraints.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.constraints` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`

warning: variable does not need to be mutable --> halo2_gadgets/src/sinsemilla_opt/chip/hash_to_point.rs:196:13 | 196 | let mut x_a: X<pallas::Base> = { | ----^^^ | | | help: remove this `mut`

warning: variable does not need to be mutable --> halo2_gadgets/src/sinsemilla_opt/chip/hash_to_point.rs:182:13 | 182 | let mut y_a: Y<pallas::Base> = { | ----^^^ | | | help: remove this `mut`

warning: variable does not need to be mutable --> halo2_gadgets/src/sinsemilla_opt/chip/hash_to_point.rs:174:13 | 174 | let mut offset = 0; | ----^^^^^^ | | | help: remove this `mut`

warning: variable does not need to be mutable --> halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs:196:13 | 196 | let mut x_a: X<pallas::Base> = { | ----^^^ | | | help: remove this `mut`

warning: variable does not need to be mutable --> halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs:182:13 | 182 | let mut y_a: Y<pallas::Base> = { | ----^^^ | | | help: remove this `mut`

warning: variable does not need to be mutable --> halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs:174:13 | 174 | let mut offset = 0; | ----^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

warning: struct `PointIndex` is never constructed --> halo2_proofs/src/plonk/circuit.rs:769:19 | 769 | pub(crate) struct PointIndex(pub usize); | ^^^^^^^^^^

warning: trait `IndexedParallelIterator` is never used --> halo2_proofs/src/multicore.rs:28:11 | 28 | pub trait IndexedParallelIterator: std::iter::Iterator {} | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unused import: `SinsemillaConfigProps` --> halo2_gadgets/src/utilities/lookup_range_check.rs:11:49 | 11 | use crate::sinsemilla::chip::{SinsemillaConfig, SinsemillaConfigProps}; | ^^^^^^^^^^^^^^^^^^^^^

warning: struct `Variable` is never constructed --> halo2_proofs/benches/plonk.rs:19:16 | 19 | pub struct Variable(Column<Advice>, usize); | ^^^^^^^^ | = note: `Variable` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/utilities_opt/lookup_range_check.rs:270:15 | 270 | use std::{convert::TryInto, marker::PhantomData}; | ^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: unused imports: `RangeConstrained`, `bitrange_subset` --> halo2_gadgets/src/utilities_opt/lookup_range_check.rs:21:24 | 21 | use crate::utilities::{bitrange_subset, RangeConstrained}; | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^

warning: unused import: `std::ops::Range` --> halo2_gadgets/src/utilities_opt/lookup_range_check.rs:5:5 | 5 | use std::ops::Range; | ^^^^^^^^^^^^^^^

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/utilities.rs:253:9 | 253 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `Error` is imported redundantly --> halo2_gadgets/src/utilities.rs:247:62 | 242 | use super::*; | -------- the item `Error` is already imported here ... 247 | plonk::{Any, Circuit, ConstraintSystem, Constraints, Error, Selector}, | ^^^^^

warning: the item `Layouter` is imported redundantly --> halo2_gadgets/src/utilities.rs:245:19 | 242 | use super::*; | -------- the item `Layouter` is already imported here ... 245 | circuit::{Layouter, SimpleFloorPlanner}, | ^^^^^^^^

warning: the item `PrimeField` is imported redundantly --> halo2_gadgets/src/utilities.rs:243:46 | 242 | use super::*; | -------- the item `PrimeField` is already imported here 243 | use group::ff::{Field, FromUniformBytes, PrimeField}; | ^^^^^^^^^^

warning: the item `Field` is imported redundantly --> halo2_gadgets/src/utilities.rs:243:21 | 242 | use super::*; | -------- the item `Field` is already imported here 243 | use group::ff::{Field, FromUniformBytes, PrimeField}; | ^^^^^

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:430:15 | 430 | use std::{convert::TryInto, marker::PhantomData}; | ^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `PrimeFieldBits` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:13:5 | 13 | use ff::PrimeFieldBits; | ^^^^^^^^^^^^^^^^^^ 14 | 15 | use super::*; | -------- the item `PrimeFieldBits` is already imported here

warning: unused import: `crate::utilities_opt::lookup_range_check::LookupRangeCheckConfigOptimized` --> halo2_gadgets/src/utilities/lookup_range_check.rs:12:5 | 12 | use crate::utilities_opt::lookup_range_check::LookupRangeCheckConfigOptimized; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `SinsemillaConfig` --> halo2_gadgets/src/utilities/lookup_range_check.rs:11:31 | 11 | use crate::sinsemilla::chip::{SinsemillaConfig, SinsemillaConfigProps}; | ^^^^^^^^^^^^^^^^

warning: the item `PhantomData` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:9:29 | 9 | use std::{convert::TryInto, marker::PhantomData}; | ^^^^^^^^^^^^^^^^^^^ ... 15 | use super::*; | -------- the item `PhantomData` is already imported here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:9:11 | 9 | use std::{convert::TryInto, marker::PhantomData}; | ^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `Error` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:6:60 | 6 | plonk::{Advice, Column, ConstraintSystem, Constraints, Error, Selector, TableColumn}, | ^^^^^ ... 15 | use super::*; | -------- the item `Error` is already imported here

warning: the item `Column` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:6:21 | 6 | plonk::{Advice, Column, ConstraintSystem, Constraints, Error, Selector, TableColumn}, | ^^^^^^ ... 15 | use super::*; | -------- the item `Column` is already imported here

warning: the item `Advice` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:6:13 | 6 | plonk::{Advice, Column, ConstraintSystem, Constraints, Error, Selector, TableColumn}, | ^^^^^^ ... 15 | use super::*; | -------- the item `Advice` is already imported here

warning: the item `Layouter` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:5:29 | 5 | circuit::{AssignedCell, Layouter, Region}, | ^^^^^^^^ ... 15 | use super::*; | -------- the item `Layouter` is already imported here

warning: the item `AssignedCell` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:5:15 | 5 | circuit::{AssignedCell, Layouter, Region}, | ^^^^^^^^^^^^ ... 15 | use super::*; | -------- the item `AssignedCell` is already imported here

warning: the item `Error` is imported redundantly --> halo2_gadgets/src/utilities/decompose_running_sum.rs:215:49 | 210 | use super::*; | -------- the item `Error` is already imported here ... 215 | plonk::{Any, Circuit, ConstraintSystem, Error}, | ^^^^^

warning: the item `ConstraintSystem` is imported redundantly --> halo2_gadgets/src/utilities/decompose_running_sum.rs:215:31 | 210 | use super::*; | -------- the item `ConstraintSystem` is already imported here ... 215 | plonk::{Any, Circuit, ConstraintSystem, Error}, | ^^^^^^^^^^^^^^^^

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:201:15 | 201 | use std::{convert::TryInto, iter}; | ^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: unused import: `lookup_range_check::LookupRangeCheckConfig` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:186:30 | 186 | utilities::{i2lebsp, lookup_range_check::LookupRangeCheckConfig, UtilitiesInstructions}, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `std::marker::PhantomData` --> halo2_gadgets/src/sinsemilla_opt/chip.rs:23:5 | 23 | use std::marker::PhantomData; | ^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused imports: `Constraints`, `Selector` --> halo2_gadgets/src/sinsemilla_opt/chip.rs:16:43 | 16 | Advice, Column, ConstraintSystem, Constraints, Error, Expression, Fixed, Selector, | ^^^^^^^^^^^ ^^^^^^^^

warning: unused imports: `DoubleAndAdd`, `utilities::lookup_range_check::LookupRangeCheckConfig` --> halo2_gadgets/src/sinsemilla_opt/chip.rs:8:16 | 8 | chip::{DoubleAndAdd, NonIdentityEccPoint}, | ^^^^^^^^^^^^ ... 11 | utilities::lookup_range_check::LookupRangeCheckConfig, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `SinsemillaChip` --> halo2_gadgets/src/sinsemilla_opt/chip/hash_to_point.rs:1:34 | 1 | use super::{NonIdentityEccPoint, SinsemillaChip, SinsemillaChipOptimized}; | ^^^^^^^^^^^^^^

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sinsemilla.rs:581:9 | 581 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sinsemilla/merkle.rs:201:15 | 201 | use std::{convert::TryInto, iter}; | ^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: unused import: `halo2_proofs::plonk::Assigned` --> halo2_gadgets/src/sinsemilla/chip.rs:34:5 | 34 | use halo2_proofs::plonk::Assigned; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `halo2_proofs::circuit::Region` --> halo2_gadgets/src/sinsemilla/chip.rs:33:5 | 33 | use halo2_proofs::circuit::Region; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused imports: `INV_TWO_POW_K`, `SINSEMILLA_S`, `lebs2ip_k` --> halo2_gadgets/src/sinsemilla/chip.rs:31:37 | 31 | use crate::sinsemilla::primitives::{lebs2ip_k, INV_TWO_POW_K, SINSEMILLA_S}; | ^^^^^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^^^

warning: unused import: `proptest::test_runner::Config` --> halo2_gadgets/src/sinsemilla/chip.rs:28:5 | 28 | use proptest::test_runner::Config; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `pasta_curves::arithmetic::CurveAffine` --> halo2_gadgets/src/sinsemilla/chip.rs:15:5 | 15 | use pasta_curves::arithmetic::CurveAffine; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `ff::PrimeField` --> halo2_gadgets/src/sinsemilla/chip.rs:14:5 | 14 | use ff::PrimeField; | ^^^^^^^^^^^^^^

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/spread_table.rs:10:5 | 10 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:8:5 | 8 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:8:5 | 8 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule/subregion1.rs:8:5 | 8 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:13:5 | 13 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/compression.rs:12:5 | 12 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256.rs:6:5 | 6 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/poseidon/primitives.rs:3:5 | 3 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/poseidon/pow5.rs:618:9 | 618 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/poseidon/pow5.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/poseidon.rs:3:5 | 3 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `pallas` is imported redundantly --> halo2_gadgets/src/ecc/chip/witness_point.rs:192:9 | 192 | use pasta_curves::pallas; | ^^^^^^^^^^^^^^^^^^^^ 193 | 194 | use super::*; | -------- the item `pallas` is already imported here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip/mul_fixed/short.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip/mul_fixed/base_field_elem.rs:19:5 | 19 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip/mul.rs:7:5 | 7 | convert::TryInto, | ^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip.rs:18:5 | 18 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here | = note: `#[warn(unused_imports)]` on by default

warning: struct `Variable` is never constructed --> halo2_proofs/tests/plonk_api.rs:26:16 | 26 | pub struct Variable(Column<Advice>, usize); | ^^^^^^^^ | = note: `Variable` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:109:13 | 109 | /// Selector assignments used for optimization pass | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 110 | selectors: vec![vec![false; n]; num_selectors], | ---------------------------------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment

warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:107:13 | 107 | /// Pairs of cells between which we have equality constraints. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 108 | equality: vec![], | ---------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment

warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:105:13 | 105 | /// Any cells assigned outside of a region. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 106 | loose_cells: vec![], | ------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment = note: `#[warn(unused_doc_comments)]` on by default

warning: the item `TryInto` is imported redundantly --> halo2_proofs/src/transcript.rs:6:5 | 6 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryFrom` is imported redundantly --> halo2_proofs/src/poly/multiopen.rs:395:9 | 395 | use std::convert::TryFrom; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryFrom` is already defined here

warning: the item `ExactSizeIterator` is imported redundantly --> halo2_proofs/src/plonk/permutation/prover.rs:6:23 | 6 | use std::iter::{self, ExactSizeIterator}; | ^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `ExactSizeIterator` is already defined here

warning: the item `TryFrom` is imported redundantly --> halo2_proofs/src/plonk/circuit.rs:5:5 | 5 | convert::TryFrom, | ^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryFrom` is already defined here

warning: unused imports: `ParallelIterator`, `Scope` --> halo2_proofs/src/multicore.rs:15:34 | 15 | iter::{IntoParallelIterator, ParallelIterator}, | ^^^^^^^^^^^^^^^^ 16 | join, scope, Scope, | ^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: unused imports: `RangeConstrained`, `bitrange_subset` --> halo2_gadgets/src/utilities_opt/lookup_range_check.rs:21:24 | 21 | use crate::utilities::{bitrange_subset, RangeConstrained}; | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^

warning: unused import: `std::ops::Range` --> halo2_gadgets/src/utilities_opt/lookup_range_check.rs:5:5 | 5 | use std::ops::Range; | ^^^^^^^^^^^^^^^

warning: the item `PrimeFieldBits` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:13:5 | 13 | use ff::PrimeFieldBits; | ^^^^^^^^^^^^^^^^^^ 14 | 15 | use super::*; | -------- the item `PrimeFieldBits` is already imported here

warning: unused import: `crate::utilities_opt::lookup_range_check::LookupRangeCheckConfigOptimized` --> halo2_gadgets/src/utilities/lookup_range_check.rs:12:5 | 12 | use crate::utilities_opt::lookup_range_check::LookupRangeCheckConfigOptimized; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `SinsemillaConfig` --> halo2_gadgets/src/utilities/lookup_range_check.rs:11:31 | 11 | use crate::sinsemilla::chip::{SinsemillaConfig, SinsemillaConfigProps}; | ^^^^^^^^^^^^^^^^

warning: the item `PhantomData` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:9:29 | 9 | use std::{convert::TryInto, marker::PhantomData}; | ^^^^^^^^^^^^^^^^^^^ ... 15 | use super::*; | -------- the item `PhantomData` is already imported here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:9:11 | 9 | use std::{convert::TryInto, marker::PhantomData}; | ^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `Error` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:6:60 | 6 | plonk::{Advice, Column, ConstraintSystem, Constraints, Error, Selector, TableColumn}, | ^^^^^ ... 15 | use super::*; | -------- the item `Error` is already imported here

warning: the item `Column` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:6:21 | 6 | plonk::{Advice, Column, ConstraintSystem, Constraints, Error, Selector, TableColumn}, | ^^^^^^ ... 15 | use super::*; | -------- the item `Column` is already imported here

warning: the item `Advice` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:6:13 | 6 | plonk::{Advice, Column, ConstraintSystem, Constraints, Error, Selector, TableColumn}, | ^^^^^^ ... 15 | use super::*; | -------- the item `Advice` is already imported here

warning: the item `Layouter` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:5:29 | 5 | circuit::{AssignedCell, Layouter, Region}, | ^^^^^^^^ ... 15 | use super::*; | -------- the item `Layouter` is already imported here

warning: the item `AssignedCell` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:5:15 | 5 | circuit::{AssignedCell, Layouter, Region}, | ^^^^^^^^^^^^ ... 15 | use super::*; | -------- the item `AssignedCell` is already imported here

warning: unused import: `std::marker::PhantomData` --> halo2_gadgets/src/sinsemilla_opt/chip.rs:23:5 | 23 | use std::marker::PhantomData; | ^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused imports: `Constraints`, `Selector` --> halo2_gadgets/src/sinsemilla_opt/chip.rs:16:43 | 16 | Advice, Column, ConstraintSystem, Constraints, Error, Expression, Fixed, Selector, | ^^^^^^^^^^^ ^^^^^^^^

warning: unused imports: `DoubleAndAdd`, `utilities::lookup_range_check::LookupRangeCheckConfig` --> halo2_gadgets/src/sinsemilla_opt/chip.rs:8:16 | 8 | chip::{DoubleAndAdd, NonIdentityEccPoint}, | ^^^^^^^^^^^^ ... 11 | utilities::lookup_range_check::LookupRangeCheckConfig, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `SinsemillaChip` --> halo2_gadgets/src/sinsemilla_opt/chip/hash_to_point.rs:1:34 | 1 | use super::{NonIdentityEccPoint, SinsemillaChip, SinsemillaChipOptimized}; | ^^^^^^^^^^^^^^

warning: unused import: `halo2_proofs::plonk::Assigned` --> halo2_gadgets/src/sinsemilla/chip.rs:34:5 | 34 | use halo2_proofs::plonk::Assigned; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `halo2_proofs::circuit::Region` --> halo2_gadgets/src/sinsemilla/chip.rs:33:5 | 33 | use halo2_proofs::circuit::Region; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused imports: `INV_TWO_POW_K`, `SINSEMILLA_S`, `lebs2ip_k` --> halo2_gadgets/src/sinsemilla/chip.rs:31:37 | 31 | use crate::sinsemilla::primitives::{lebs2ip_k, INV_TWO_POW_K, SINSEMILLA_S}; | ^^^^^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^^^

warning: unused import: `proptest::test_runner::Config` --> halo2_gadgets/src/sinsemilla/chip.rs:28:5 | 28 | use proptest::test_runner::Config; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `pasta_curves::arithmetic::CurveAffine` --> halo2_gadgets/src/sinsemilla/chip.rs:15:5 | 15 | use pasta_curves::arithmetic::CurveAffine; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `ff::PrimeField` --> halo2_gadgets/src/sinsemilla/chip.rs:14:5 | 14 | use ff::PrimeField; | ^^^^^^^^^^^^^^

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/spread_table.rs:10:5 | 10 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:8:5 | 8 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:8:5 | 8 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule/subregion1.rs:8:5 | 8 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:13:5 | 13 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/compression.rs:12:5 | 12 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256.rs:6:5 | 6 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/poseidon/primitives.rs:3:5 | 3 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/poseidon/pow5.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/poseidon.rs:3:5 | 3 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip/mul_fixed/short.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip/mul_fixed/base_field_elem.rs:19:5 | 19 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip/mul.rs:7:5 | 7 | convert::TryInto, | ^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip.rs:18:5 | 18 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here | = note: `#[warn(unused_imports)]` on by default

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:414:33 | 414 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:371:33 | 371 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:328:33 | 328 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:174:22 | 174 | .zip(inv_denoms.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: this bound is already specified as the supertrait of `ExactSizeIterator` --> halo2_proofs/src/poly.rs:167:26 | 167 | inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls = note: `-W clippy::implied-bounds-in-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::implied_bounds_in_impls)]` help: try removing this bound | 167 - inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, 167 + inv_denoms: impl ExactSizeIterator<Item = F>, |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:159:14 | 159 | .zip(assigned_denominators.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: assigning the result of `Clone::clone()` may be inefficient --> halo2_proofs/src/poly/multiopen.rs:208:17 | 208 | point_index_set = point_idx_set.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `point_index_set.clone_from(point_idx_set)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `-W clippy::assigning-clones` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::assigning_clones)]`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly/multiopen/prover.rs:105:58 | 105 | let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold( | ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:124:36 | 124 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:78:36 | 78 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:319:25 | 319 | / lookups 320 | | .iter() 321 | | .flat_map(move |p| p.queries(vk, x)) 322 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 319 ~ lookups 320 + .iter() 321 ~ .flat_map(move |p| p.queries(vk, x)), |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:259:25 | 259 | / lookups 260 | | .iter() 261 | | .zip(vk.cs.lookups.iter()) 262 | | .flat_map(move |(p, argument)| { ... | 275 | | }) 276 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 259 ~ lookups 260 + .iter() 261 + .zip(vk.cs.lookups.iter()) 262 + .flat_map(move |(p, argument)| { 263 + p.expressions( 264 + l_0, 265 + l_last, 266 + l_blind, 267 + argument, 268 + theta, 269 + beta, 270 + gamma, 271 + advice_evals, 272 + fixed_evals, 273 + instance_evals, 274 + ) 275 ~ }), |

warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/verifier.rs:206:24 | 206 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:707:24 | 707 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookups.iter().flat_map(move |p| p.open(pk, x))` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/prover.rs:599:20 | 599 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:581:28 | 581 | .chain(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:547:14 | 547 | .zip(lookup_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookup_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:546:14 | 546 | .zip(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:1261:22 | 1261 | .zip(degrees.into_iter()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `degrees` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:893:18 | 893 | .zip(self.constraints.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.constraints` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`

warning: struct `PointIndex` is never constructed --> halo2_proofs/src/plonk/circuit.rs:769:19 | 769 | pub(crate) struct PointIndex(pub usize); | ^^^^^^^^^^

warning: trait `IndexedParallelIterator` is never used --> halo2_proofs/src/multicore.rs:28:11 | 28 | pub trait IndexedParallelIterator: std::iter::Iterator {} | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:109:13 | 109 | /// Selector assignments used for optimization pass | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 110 | selectors: vec![vec![false; n]; num_selectors], | ---------------------------------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment

warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:107:13 | 107 | /// Pairs of cells between which we have equality constraints. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 108 | equality: vec![], | ---------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment

warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:105:13 | 105 | /// Any cells assigned outside of a region. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 106 | loose_cells: vec![], | ------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment = note: `#[warn(unused_doc_comments)]` on by default

warning: the item `TryInto` is imported redundantly --> halo2_proofs/src/transcript.rs:6:5 | 6 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here

warning: the item `ExactSizeIterator` is imported redundantly --> halo2_proofs/src/plonk/permutation/prover.rs:6:23 | 6 | use std::iter::{self, ExactSizeIterator}; | ^^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `ExactSizeIterator` is already defined here

warning: the item `TryFrom` is imported redundantly --> halo2_proofs/src/plonk/circuit.rs:5:5 | 5 | convert::TryFrom, | ^^^^^^^^^^^^^^^^ --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryFrom` is already defined here

warning: unused imports: `ParallelIterator`, `Scope` --> halo2_proofs/src/multicore.rs:15:34 | 15 | iter::{IntoParallelIterator, ParallelIterator}, | ^^^^^^^^^^^^^^^^ 16 | join, scope, Scope, | ^^^^^ | = note: `#[warn(unused_imports)]` on by default

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`

unused import: `Scope`

unused doc comment

unused doc comment

unused doc comment

field `0` is never read

`halo2_proofs` (lib) generated 5 warnings (run `cargo fix --lib -p halo2_proofs` to apply 1 suggestion)

unused import: `ff::PrimeField`

unused import: `pasta_curves::arithmetic::CurveAffine`

unused import: `proptest::test_runner::Config`

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

build failed, waiting for other jobs to finish...

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

unused import: `ff::PrimeField`

unused import: `pasta_curves::arithmetic::CurveAffine`

unused imports: `INV_TWO_POW_K`, `SINSEMILLA_S`, `lebs2ip_k`

unused import: `halo2_proofs::circuit::Region`

unused import: `halo2_proofs::plonk::Assigned`

unused import: `SinsemillaChip`

unused imports: `DoubleAndAdd`, `utilities::lookup_range_check::LookupRangeCheckConfig`

unused imports: `Constraints`, `Selector`

unused import: `std::marker::PhantomData`

unused import: `SinsemillaConfig`

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

unused import: `ff::PrimeField`

unused import: `pasta_curves::arithmetic::CurveAffine`

unused imports: `INV_TWO_POW_K`, `SINSEMILLA_S`, `lebs2ip_k`

unused import: `halo2_proofs::circuit::Region`

unused import: `halo2_proofs::plonk::Assigned`

unused import: `SinsemillaChip`

unused imports: `DoubleAndAdd`, `utilities::lookup_range_check::LookupRangeCheckConfig`

unused imports: `Constraints`, `Selector`

unused import: `std::marker::PhantomData`

unused import: `SinsemillaConfig`

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

unused import: `ff::PrimeField`

unused import: `pasta_curves::arithmetic::CurveAffine`

unused import: `proptest::test_runner::Config`

unused imports: `INV_TWO_POW_K`, `SINSEMILLA_S`, `lebs2ip_k`

unused import: `halo2_proofs::circuit::Region`

unused import: `halo2_proofs::plonk::Assigned`

unused import: `SinsemillaChip`

unused imports: `DoubleAndAdd`, `utilities::lookup_range_check::LookupRangeCheckConfig`

unused imports: `Constraints`, `Selector`

unused import: `std::marker::PhantomData`

unused import: `ff::PrimeField`

unused import: `pasta_curves::arithmetic::CurveAffine`

unused import: `proptest::test_runner::Config`

unused imports: `INV_TWO_POW_K`, `SINSEMILLA_S`, `lebs2ip_k`

unused import: `halo2_proofs::circuit::Region`

unused import: `halo2_proofs::plonk::Assigned`

unused import: `SinsemillaChip`

unused imports: `DoubleAndAdd`, `utilities::lookup_range_check::LookupRangeCheckConfig`

unused imports: `Constraints`, `Selector`

unused import: `std::marker::PhantomData`

unused import: `ff::PrimeField`

unused import: `pasta_curves::arithmetic::CurveAffine`

unused import: `proptest::test_runner::Config`

unused imports: `INV_TWO_POW_K`, `SINSEMILLA_S`, `lebs2ip_k`

unused import: `halo2_proofs::circuit::Region`

unused import: `halo2_proofs::plonk::Assigned`

unused import: `SinsemillaChip`

unused imports: `DoubleAndAdd`, `utilities::lookup_range_check::LookupRangeCheckConfig`

unused imports: `Constraints`, `Selector`

unused import: `std::marker::PhantomData`

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/