Skip to content

Commit

Permalink
update lookup_range_check
Browse files Browse the repository at this point in the history
  • Loading branch information
YaoGalteland committed Mar 21, 2024
1 parent 75de4f6 commit 9ef46c3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion halo2_gadgets/src/utilities/lookup_range_check.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,8 @@ impl<F: PrimeFieldBits, const K: usize> LookupRangeCheckConfig<F, K> {
)
}

pub fn create_lookup_subtable(&self, table: &mut Table<F>, index_start: usize, index_size: usize) -> Result<(), Error> {
// create a lookup range check subtable for an 'index_size'-bit
fn create_lookup_subtable(&self, table: &mut Table<F>, index_start: usize, index_size: usize) -> Result<(), Error> {

Check warning on line 233 in halo2_gadgets/src/utilities/lookup_range_check.rs

View workflow job for this annotation

GitHub Actions / Clippy (beta)

method `create_lookup_subtable` is never used 

warning: method `create_lookup_subtable` is never used
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:233:8
    |
79  | impl<F: PrimeFieldBits, const K: usize> LookupRangeCheckConfig<F, K> {
    | -------------------------------------------------------------------- method in this implementation
...
233 |     fn create_lookup_subtable(&self, table: &mut Table<F>, index_start: usize, index_size: usize) -> Result<(), Error> {
    |        ^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

Check warning on line 233 in halo2_gadgets/src/utilities/lookup_range_check.rs

View workflow job for this annotation

GitHub Actions / Book tests 

associated function is never used: `create_lookup_subtable`

Check warning on line 233 in halo2_gadgets/src/utilities/lookup_range_check.rs

View workflow job for this annotation

GitHub Actions / Build target wasm32-wasi 

associated function is never used: `create_lookup_subtable`

Check warning on line 233 in halo2_gadgets/src/utilities/lookup_range_check.rs

View workflow job for this annotation

GitHub Actions / Build target wasm32-unknown-unknown 

associated function is never used: `create_lookup_subtable`

Check warning on line 233 in halo2_gadgets/src/utilities/lookup_range_check.rs

View workflow job for this annotation

GitHub Actions / Bitrot check 

method `create_lookup_subtable` is never used

Check warning on line 233 in halo2_gadgets/src/utilities/lookup_range_check.rs

View workflow job for this annotation

GitHub Actions / Test on macOS-latest 

associated function is never used: `create_lookup_subtable`

Check warning on line 233 in halo2_gadgets/src/utilities/lookup_range_check.rs

View workflow job for this annotation

GitHub Actions / Test on ubuntu-latest 

associated function is never used: `create_lookup_subtable`

Check warning on line 233 in halo2_gadgets/src/utilities/lookup_range_check.rs

View workflow job for this annotation

GitHub Actions / Test on ubuntu-latest with beta features 

associated function is never used: `create_lookup_subtable`

Check warning on line 233 in halo2_gadgets/src/utilities/lookup_range_check.rs

View workflow job for this annotation

GitHub Actions / Test on ubuntu-latest with nightly features 

associated function is never used: `create_lookup_subtable`

Check warning on line 233 in halo2_gadgets/src/utilities/lookup_range_check.rs

View workflow job for this annotation

GitHub Actions / Test on macOS-latest with beta features 

associated function is never used: `create_lookup_subtable`

Check warning on line 233 in halo2_gadgets/src/utilities/lookup_range_check.rs

View workflow job for this annotation

GitHub Actions / Test on windows-latest with beta features 

associated function is never used: `create_lookup_subtable`

Check warning on line 233 in halo2_gadgets/src/utilities/lookup_range_check.rs

View workflow job for this annotation

GitHub Actions / Test on macOS-latest with nightly features 

associated function is never used: `create_lookup_subtable`

Check warning on line 233 in halo2_gadgets/src/utilities/lookup_range_check.rs

View workflow job for this annotation

GitHub Actions / Test on windows-latest 

associated function is never used: `create_lookup_subtable`

Check warning on line 233 in halo2_gadgets/src/utilities/lookup_range_check.rs

View workflow job for this annotation

GitHub Actions / Test on windows-latest with nightly features 

associated function is never used: `create_lookup_subtable`
for index in 0..(1 << index_size) {
let new_index = index + index_start;
table.assign_cell(
Expand Down

0 comments on commit 9ef46c3

Please sign in to comment.