Add necessary features for ZSA integration #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcuit Previously, the functions test_against_stored_vk and test_against_stored_proof each generated a verification key (vk). This operation can be quite slow. We are combining these two tests to generate the vk only once.
LookupRangeCheck45BConfig <- LookupRangeCheckConfigOptimized PallasLookupRangeCheck <- PallasLookupRC PallasLookupRangeCheckConfig <- PallasLookupRCConfig PallasLookupRangeCheck45BConfig <- PallasLookupConfigOptimized
Sinsemilla45BChip <- SinsemillaChipOptimized Sinsemilla45BInstructions <- SinsemillaInstructionsOptimized Merkle45BChip <- MerkleChipOptimized
Previously, the SinsemillaChip always loaded the lookup range check without tag column and Sinsemilla45BChip always loaded the lookup range check with tag column. Now, we load lookup range check with or without tag according to the lookup type (LookupRangeCheckConfig or LookupRangeCheck45BConfig).
It is now possible to use Sinsemilla/Merkle45BChip with non optimized lookup.
SinsemillaWithPrivateInitChip <- Sinsemilla45BChip SinsemillaWithPrivateInitInstructions <- Sinsemilla45BInstructions MerkleWithPrivateInitChip <- Merkle45BChip
…oint variable We add enable_hash_from_private_point into SinsemillaChip in order to put together SinsemillaChip and SinsemillaWithPrivateInitChip. If enable_hash_from_private_point is set, it is possible to hash from a private point. Otherwise, it is not allowed. That allows also to put together MerkleChip and MerkleWithPrivateInitChip.
…compatibility-based-on-previous-pr
ConstanceBeguier
force-pushed
the
backward-compatibility-based-on-previous-pr
branch
2 times, most recently
from
6bcce18 to
ab9e619
Compare
ConstanceBeguier
force-pushed
the
backward-compatibility-based-on-previous-pr
branch
from
ab9e619 to
9af61eb
Compare
ConstanceBeguier
changed the base branch from
improve-backward-compatability-without-zsa
to
zsa1
ConstanceBeguier
changed the base branch from
zsa1
to
improve-backward-compatability-without-zsa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO