Skip to content

Add LookupRangeCheckConfigDomain trait, split LookupRangeCheckConfig …

Sign in for the full log view
GitHub Actions / Clippy (beta) failed Apr 7, 2024 in 3s

Clippy (beta)

4 errors, 150 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 4
Warning 150
Note 0
Help 0

Versions

  • rustc 1.78.0-beta.5 (9eff51035 2024-04-06)
  • cargo 1.78.0-beta.5 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9eff510 2024-04-06)

Annotations

Check warning on line 127 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:127:34
    |
127 |             _phantom: PhantomData::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 118 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:118:34
    |
118 |             _phantom: PhantomData::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 103 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:103:34
    |
103 |             _phantom: PhantomData::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check failure on line 599 in halo2_gadgets/src/sinsemilla.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

mismatched types 

error[E0308]: mismatched types
   --> halo2_gadgets/src/sinsemilla.rs:599:17
    |
593 |             let config2 = SinsemillaChip::configure(
    |                           ------------------------- arguments to this function are incorrect
...
599 |                 range_check,
    |                 ^^^^^^^^^^^ expected `LookupRangeCheckConfigOptimized<Fp, 10>`, found `LookupRangeCheckConfig<Fp, 10>`
    |
    = note: expected struct `utilities_opt::lookup_range_check::LookupRangeCheckConfigOptimized<pasta_curves::Fp, 10>`
               found struct `utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>`
note: associated function defined here
   --> halo2_gadgets/src/sinsemilla/chip.rs:156:12
    |
156 |     pub fn configure(
    |            ^^^^^^^^^
...
162 |         range_check: LookupRangeCheckConfigOptimized<pallas::Base, { sinsemilla::K }>,
    |         -----------------------------------------------------------------------------

Check failure on line 591 in halo2_gadgets/src/sinsemilla.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

mismatched types 

error[E0308]: mismatched types
   --> halo2_gadgets/src/sinsemilla.rs:591:17
    |
585 |             let config1 = SinsemillaChip::configure(
    |                           ------------------------- arguments to this function are incorrect
...
591 |                 range_check,
    |                 ^^^^^^^^^^^ expected `LookupRangeCheckConfigOptimized<Fp, 10>`, found `LookupRangeCheckConfig<Fp, 10>`
    |
    = note: expected struct `utilities_opt::lookup_range_check::LookupRangeCheckConfigOptimized<pasta_curves::Fp, 10>`
               found struct `utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>`
note: associated function defined here
   --> halo2_gadgets/src/sinsemilla/chip.rs:156:12
    |
156 |     pub fn configure(
    |            ^^^^^^^^^
...
162 |         range_check: LookupRangeCheckConfigOptimized<pallas::Base, { sinsemilla::K }>,
    |         -----------------------------------------------------------------------------

Check failure on line 273 in halo2_gadgets/src/sinsemilla/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

mismatched types 

error[E0308]: mismatched types
   --> halo2_gadgets/src/sinsemilla/merkle.rs:273:17
    |
267 |             let sinsemilla_config_2 = SinsemillaChip::configure(
    |                                       ------------------------- arguments to this function are incorrect
...
273 |                 range_check,
    |                 ^^^^^^^^^^^ expected `LookupRangeCheckConfigOptimized<Fp, 10>`, found `LookupRangeCheckConfig<Fp, _>`
    |
    = note: expected struct `utilities_opt::lookup_range_check::LookupRangeCheckConfigOptimized<pasta_curves::Fp, 10>`
               found struct `utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, _>`
note: associated function defined here
   --> halo2_gadgets/src/sinsemilla/chip.rs:156:12
    |
156 |     pub fn configure(
    |            ^^^^^^^^^
...
162 |         range_check: LookupRangeCheckConfigOptimized<pallas::Base, { sinsemilla::K }>,
    |         -----------------------------------------------------------------------------

Check failure on line 263 in halo2_gadgets/src/sinsemilla/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

mismatched types 

error[E0308]: mismatched types
   --> halo2_gadgets/src/sinsemilla/merkle.rs:263:17
    |
257 |             let sinsemilla_config_1 = SinsemillaChip::configure(
    |                                       ------------------------- arguments to this function are incorrect
...
263 |                 range_check,
    |                 ^^^^^^^^^^^ expected `LookupRangeCheckConfigOptimized<Fp, 10>`, found `LookupRangeCheckConfig<Fp, _>`
    |
    = note: expected struct `utilities_opt::lookup_range_check::LookupRangeCheckConfigOptimized<pasta_curves::Fp, 10>`
               found struct `utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, _>`
note: associated function defined here
   --> halo2_gadgets/src/sinsemilla/chip.rs:156:12
    |
156 |     pub fn configure(
    |            ^^^^^^^^^
...
162 |         range_check: LookupRangeCheckConfigOptimized<pallas::Base, { sinsemilla::K }>,
    |         -----------------------------------------------------------------------------

Check warning on line 1066 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Iterator::fold` on a type that implements `Try` 

warning: usage of `Iterator::fold` on a type that implements `Try`
    --> halo2_proofs/src/dev.rs:1066:30
     |
1066 | ...                   .fold(Ok(()), |acc, res| acc.and(res))
     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold((), |acc, res| ...)`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
     = note: `-W clippy::manual-try-fold` implied by `-W clippy::all`
     = help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`

Check warning on line 414 in halo2_proofs/src/dev/cost.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/dev/cost.rs:414:33
    |
414 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 371 in halo2_proofs/src/dev/cost.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/dev/cost.rs:371:33
    |
371 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 328 in halo2_proofs/src/dev/cost.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/dev/cost.rs:328:33
    |
328 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 206 in halo2_gadgets/src/poseidon.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/poseidon.rs:206:33
    |
206 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 159 in halo2_gadgets/src/poseidon.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/poseidon.rs:159:33
    |
159 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 363 in halo2_gadgets/src/poseidon/primitives.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/poseidon/primitives.rs:363:33
    |
363 |             _domain: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 257 in halo2_gadgets/src/poseidon/primitives.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/poseidon/primitives.rs:257:33
    |
257 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 220 in halo2_gadgets/src/poseidon/primitives.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/poseidon/primitives.rs:220:33
    |
220 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 174 in halo2_proofs/src/poly.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/poly.rs:174:22
    |
174 |                 .zip(inv_denoms.into_iter())
    |                      ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/9eff5103597e0ce73244028c96c75866dbcbad1d/library/core/src/iter/traits/iterator.rs:602:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 167 in halo2_proofs/src/poly.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this bound is already specified as the supertrait of `ExactSizeIterator` 

warning: this bound is already specified as the supertrait of `ExactSizeIterator`
   --> halo2_proofs/src/poly.rs:167:26
    |
167 |         inv_denoms: impl Iterator<Item = F> + ExactSizeIterator,
    |                          ^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
    = note: `-W clippy::implied-bounds-in-impls` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::implied_bounds_in_impls)]`
help: try removing this bound
    |
167 -         inv_denoms: impl Iterator<Item = F> + ExactSizeIterator,
167 +         inv_denoms: impl ExactSizeIterator<Item = F>,
    |

Check warning on line 159 in halo2_proofs/src/poly.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/poly.rs:159:14
    |
159 |         .zip(assigned_denominators.into_iter())
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/9eff5103597e0ce73244028c96c75866dbcbad1d/library/core/src/iter/traits/iterator.rs:602:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 72 in halo2_gadgets/src/poseidon/primitives/grain.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
  --> halo2_gadgets/src/poseidon/primitives/grain.rs:72:32
   |
72 |             _field: PhantomData::default(),
   |                                ^^^^^^^^^^^ help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
   = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`
   = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`

Check warning on line 208 in halo2_proofs/src/poly/multiopen.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

assigning the result of `Clone::clone()` may be inefficient 

warning: assigning the result of `Clone::clone()` may be inefficient
   --> halo2_proofs/src/poly/multiopen.rs:208:17
    |
208 |                 point_index_set = point_idx_set.clone();
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `point_index_set.clone_from(point_idx_set)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
    = note: `-W clippy::assigning-clones` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::assigning_clones)]`

Check warning on line 105 in halo2_proofs/src/poly/multiopen/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/poly/multiopen/prover.rs:105:58
    |
105 |     let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold(
    |                                                          ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/9eff5103597e0ce73244028c96c75866dbcbad1d/library/core/src/iter/traits/iterator.rs:602:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 517 in halo2_gadgets/src/poseidon/pow5.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits 

warning: the borrowed expression implements the required traits
   --> halo2_gadgets/src/poseidon/pow5.rs:517:77
    |
517 |                 let r_0 = (p[0] + config.round_constants[round + 1][0]).pow(&config.alpha);
    |                                                                             ^^^^^^^^^^^^^ help: change this to: `config.alpha`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 477 in halo2_gadgets/src/poseidon/pow5.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits 

warning: the borrowed expression implements the required traits
   --> halo2_gadgets/src/poseidon/pow5.rs:477:73
    |
477 |                 let r_0 = (p[0] + config.round_constants[round][0]).pow(&config.alpha);
    |                                                                         ^^^^^^^^^^^^^ help: change this to: `config.alpha`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 451 in halo2_gadgets/src/poseidon/pow5.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits 

warning: the borrowed expression implements the required traits
   --> halo2_gadgets/src/poseidon/pow5.rs:451:62
    |
451 |             let r: Value<Vec<F>> = q.map(|q| q.map(|q| q.pow(&config.alpha))).collect();
    |                                                              ^^^^^^^^^^^^^ help: change this to: `config.alpha`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
View more details on GitHub Actions