Skip to content

add comments

Sign in for the full log view
GitHub Actions / Clippy (beta) failed Apr 15, 2024 in 3s

Clippy (beta)

9 errors, 190 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 9
Warning 190
Note 0
Help 0

Versions

  • rustc 1.78.0-beta.7 (6fd191292 2024-04-12)
  • cargo 1.78.0-beta.7 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (6fd1912 2024-04-12)

Annotations

Check warning on line 162 in halo2_gadgets/src/sinsemilla/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variable `Y_A_next` should have a snake case name 

warning: variable `Y_A_next` should have a snake case name
   --> halo2_gadgets/src/sinsemilla/chip.rs:162:17
    |
162 |             let Y_A_next = Y_A(meta, Rotation::next());
    |                 ^^^^^^^^ help: convert the identifier to snake case: `y_a_next`

Check warning on line 159 in halo2_gadgets/src/sinsemilla/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variable `Y_A_cur` should have a snake case name 

warning: variable `Y_A_cur` should have a snake case name
   --> halo2_gadgets/src/sinsemilla/chip.rs:159:17
    |
159 |             let Y_A_cur = Y_A(meta, Rotation::cur());
    |                 ^^^^^^^ help: convert the identifier to snake case: `y_a_cur`

Check warning on line 135 in halo2_gadgets/src/sinsemilla/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variable `Y_A_cur` should have a snake case name 

warning: variable `Y_A_cur` should have a snake case name
   --> halo2_gadgets/src/sinsemilla/chip.rs:135:17
    |
135 |             let Y_A_cur = Y_A(meta, Rotation::cur());
    |                 ^^^^^^^ help: convert the identifier to snake case: `y_a_cur`

Check warning on line 124 in halo2_gadgets/src/sinsemilla/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variable `Y_A` should have a snake case name 

warning: variable `Y_A` should have a snake case name
   --> halo2_gadgets/src/sinsemilla/chip.rs:124:13
    |
124 |         let Y_A = |meta: &mut VirtualCells<pallas::Base>, rotation| {
    |             ^^^ help: convert the identifier to snake case: `y_a`
    |
    = note: `#[warn(non_snake_case)]` on by default

Check warning on line 407 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

an array of `Range` that is only one element 

warning: an array of `Range` that is only one element
   --> halo2_gadgets/src/utilities.rs:407:47
    |
407 |         decompose(pallas::Base::random(rng), &[0..255]);
    |                                               ^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init
    = note: `-W clippy::single-range-in-vec-init` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::single_range_in_vec_init)]`
help: if you wanted a `Vec` that contains the entire range, try
    |
407 |         decompose(pallas::Base::random(rng), &(0..255).collect::<std::vec::Vec<usize>>());
    |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: if you wanted an array of len 255, try
    |
407 |         decompose(pallas::Base::random(rng), &[0; 255]);
    |                                                ~~~~~~

Check warning on line 127 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:127:34
    |
127 |             _phantom: PhantomData::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 118 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:118:34
    |
118 |             _phantom: PhantomData::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 103 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:103:34
    |
103 |             _phantom: PhantomData::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 49 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
  --> halo2_gadgets/src/utilities/lookup_range_check.rs:49:34
   |
49 |             _phantom: PhantomData::default(),
   |                                  ^^^^^^^^^^^ help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 759 in halo2_gadgets/src/sinsemilla.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_gadgets/src/sinsemilla.rs:759:48
    |
759 | ...                   .chain(right.into_iter()),
    |                              ^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `right`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:483:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 758 in halo2_gadgets/src/sinsemilla.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_gadgets/src/sinsemilla.rs:758:48
    |
758 | ...                   .chain(left.into_iter())
    |                              ^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `left`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/6fd1912922a7b468b1875d16571bb7a00d5df93f/library/core/src/iter/traits/iterator.rs:483:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-W clippy::useless-conversion` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`

Check warning on line 351 in halo2_gadgets/src/sinsemilla/primitives.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/sinsemilla/primitives.rs:351:31
    |
351 |         let mut os_rng = OsRng::default();
    |                               ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check failure on line 37 in halo2_gadgets/src/utilities/cond_swap.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

missing documentation for a method 

error: missing documentation for a method
  --> halo2_gadgets/src/utilities/cond_swap.rs:31:5
   |
31 | /     fn mux(
32 | |         &self,
33 | |         layouter: &mut impl Layouter<F>,
34 | |         choice: Self::Var,
35 | |         left: Self::Var,
36 | |         right: Self::Var,
37 | |     ) -> Result<Self::Var, Error>;
   | |__________________________________^

Check failure on line 1 in halo2_gadgets/src/sinsemilla_opt.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

missing documentation for a module 

error: missing documentation for a module
 --> halo2_gadgets/src/sinsemilla_opt.rs:1:1
  |
1 | pub mod chip;
  | ^^^^^^^^^^^^

Check failure on line 239 in halo2_gadgets/src/sinsemilla/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

missing documentation for a method 

error: missing documentation for a method
   --> halo2_gadgets/src/sinsemilla/chip.rs:239:5
    |
239 |     fn base(&self) -> &SinsemillaConfigCommon<Hash, Commit, F>;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 237 in halo2_gadgets/src/sinsemilla/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

missing documentation for an associated type 

error: missing documentation for an associated type
   --> halo2_gadgets/src/sinsemilla/chip.rs:237:5
    |
237 |     type LookupType;
    |     ^^^^^^^^^^^^^^^

Check failure on line 236 in halo2_gadgets/src/sinsemilla/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

missing documentation for an associated type 

error: missing documentation for an associated type
   --> halo2_gadgets/src/sinsemilla/chip.rs:236:5
    |
236 |     type SinsemillaConfigType: SinsemillaConfigProps<Hash, Commit, F>;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 235 in halo2_gadgets/src/sinsemilla/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

missing documentation for an associated type 

error: missing documentation for an associated type
   --> halo2_gadgets/src/sinsemilla/chip.rs:235:5
    |
235 |     type RangeCheckConfigType;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 233 in halo2_gadgets/src/sinsemilla/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

missing documentation for an associated type 

error: missing documentation for an associated type
   --> halo2_gadgets/src/sinsemilla/chip.rs:233:5
    |
233 |     type Loaded;
    |     ^^^^^^^^^^^

Check warning on line 162 in halo2_gadgets/src/sinsemilla/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variable `Y_A_next` should have a snake case name 

warning: variable `Y_A_next` should have a snake case name
   --> halo2_gadgets/src/sinsemilla/chip.rs:162:17
    |
162 |             let Y_A_next = Y_A(meta, Rotation::next());
    |                 ^^^^^^^^ help: convert the identifier to snake case: `y_a_next`

Check warning on line 159 in halo2_gadgets/src/sinsemilla/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variable `Y_A_cur` should have a snake case name 

warning: variable `Y_A_cur` should have a snake case name
   --> halo2_gadgets/src/sinsemilla/chip.rs:159:17
    |
159 |             let Y_A_cur = Y_A(meta, Rotation::cur());
    |                 ^^^^^^^ help: convert the identifier to snake case: `y_a_cur`

Check warning on line 135 in halo2_gadgets/src/sinsemilla/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variable `Y_A_cur` should have a snake case name 

warning: variable `Y_A_cur` should have a snake case name
   --> halo2_gadgets/src/sinsemilla/chip.rs:135:17
    |
135 |             let Y_A_cur = Y_A(meta, Rotation::cur());
    |                 ^^^^^^^ help: convert the identifier to snake case: `y_a_cur`

Check warning on line 124 in halo2_gadgets/src/sinsemilla/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variable `Y_A` should have a snake case name 

warning: variable `Y_A` should have a snake case name
   --> halo2_gadgets/src/sinsemilla/chip.rs:124:13
    |
124 |         let Y_A = |meta: &mut VirtualCells<pallas::Base>, rotation| {
    |             ^^^ help: convert the identifier to snake case: `y_a`
    |
    = note: `#[warn(non_snake_case)]` on by default

Check failure on line 82 in halo2_gadgets/src/sinsemilla/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

missing documentation for an associated type 

error: missing documentation for an associated type
  --> halo2_gadgets/src/sinsemilla/chip.rs:82:5
   |
82 |     type LookupConfigType;
   |     ^^^^^^^^^^^^^^^^^^^^^

Check failure on line 31 in halo2_gadgets/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

missing documentation for a module 

error: missing documentation for a module
  --> halo2_gadgets/src/lib.rs:31:1
   |
31 | pub mod sinsemilla_opt;
   | ^^^^^^^^^^^^^^^^^^^^^^
   |
note: the lint level is defined here
  --> halo2_gadgets/src/lib.rs:21:9
   |
21 | #![deny(missing_docs)]
   |         ^^^^^^^^^^^^
View more details on GitHub Actions