Skip to content

Use sinsemilla_chip as a parameter of MerkleConfig instead of sinsemi…

Sign in for the full log view
GitHub Actions / Clippy (beta) failed Apr 25, 2024 in 4s

Clippy (beta)

164 errors, 66 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 164
Warning 66
Note 0
Help 0

Versions

  • rustc 1.78.0-beta.9 (205af5d6b 2024-04-23)
  • cargo 1.78.0-beta.9 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (205af5d 2024-04-23)

Annotations

Check warning on line 82 in halo2_gadgets/src/ecc_opt/chip/mul_fixed/short.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `Chip` 

warning: unused import: `Chip`
  --> halo2_gadgets/src/ecc_opt/chip/mul_fixed/short.rs:82:33
   |
82 |         circuit::{AssignedCell, Chip, Layouter, Value},
   |                                 ^^^^

Check warning on line 91 in halo2_gadgets/src/ecc_opt/chip/mul_fixed/short.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `UtilitiesInstructions` 

warning: unused import: `UtilitiesInstructions`
  --> halo2_gadgets/src/ecc_opt/chip/mul_fixed/short.rs:91:13
   |
91 |             UtilitiesInstructions,
   |             ^^^^^^^^^^^^^^^^^^^^^

Check warning on line 264 in halo2_gadgets/src/ecc/chip/mul_fixed/short.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `UtilitiesInstructions` 

warning: unused import: `UtilitiesInstructions`
   --> halo2_gadgets/src/ecc/chip/mul_fixed/short.rs:264:13
    |
264 |             UtilitiesInstructions,
    |             ^^^^^^^^^^^^^^^^^^^^^

Check warning on line 251 in halo2_gadgets/src/ecc/chip/mul_fixed/short.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `Chip` 

warning: unused import: `Chip`
   --> halo2_gadgets/src/ecc/chip/mul_fixed/short.rs:251:33
    |
251 |         circuit::{AssignedCell, Chip, Layouter, Value},
    |                                 ^^^^

Check warning on line 400 in halo2_gadgets/src/ecc/chip/mul_fixed/base_field_elem.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `utilities::UtilitiesInstructions` 

warning: unused import: `utilities::UtilitiesInstructions`
   --> halo2_gadgets/src/ecc/chip/mul_fixed/base_field_elem.rs:400:9
    |
400 |         utilities::UtilitiesInstructions,
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 388 in halo2_gadgets/src/ecc/chip/mul_fixed/base_field_elem.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `Chip` 

warning: unused import: `Chip`
   --> halo2_gadgets/src/ecc/chip/mul_fixed/base_field_elem.rs:388:19
    |
388 |         circuit::{Chip, Layouter, Value},
    |                   ^^^^

Check warning on line 476 in halo2_gadgets/src/ecc/chip/mul.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `utilities::UtilitiesInstructions` 

warning: unused import: `utilities::UtilitiesInstructions`
   --> halo2_gadgets/src/ecc/chip/mul.rs:476:9
    |
476 |         utilities::UtilitiesInstructions,
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 464 in halo2_gadgets/src/ecc/chip/mul.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `Chip` 

warning: unused import: `Chip`
   --> halo2_gadgets/src/ecc/chip/mul.rs:464:19
    |
464 |         circuit::{Chip, Layouter, Value},
    |                   ^^^^

Check failure on line 211 in halo2_gadgets/src/utilities_opt/cond_swap.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

struct takes 2 generic arguments but 1 generic argument was supplied 

error[E0107]: struct takes 2 generic arguments but 1 generic argument was supplied
   --> halo2_gadgets/src/utilities_opt/cond_swap.rs:211:34
    |
211 |                 let ecc_config = EccChip::<TestFixedBases>::configure(
    |                                  ^^^^^^^   -------------- supplied 1 generic argument
    |                                  |
    |                                  expected 2 generic arguments
    |
note: struct defined here, with 2 generic parameters: `FixedPoints`, `LookupRangeCheckConfig`
   --> halo2_gadgets/src/ecc/chip.rs:230:12
    |
230 | pub struct EccChip<
    |            ^^^^^^^
231 |     FixedPoints: super::FixedPoints<pallas::Affine>,
    |     -----------
232 |     LookupRangeCheckConfig: DefaultLookupRangeCheck,
    |     ----------------------
help: add missing generic argument
    |
211 |                 let ecc_config = EccChip::<TestFixedBases, LookupRangeCheckConfig>::configure(
    |                                                          ++++++++++++++++++++++++

Check failure on line 52 in halo2_gadgets/src/sinsemilla_opt/chip/hash_to_point.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

no function or associated item named `check_hash_result` found for struct `sinsemilla_opt::chip::SinsemillaChipOptimized` in the current scope 

error[E0599]: no function or associated item named `check_hash_result` found for struct `sinsemilla_opt::chip::SinsemillaChipOptimized` in the current scope
  --> halo2_gadgets/src/sinsemilla_opt/chip/hash_to_point.rs:52:15
   |
52 |         Self::check_hash_result(&Q, message, &x_a, &y_a);
   |               ^^^^^^^^^^^^^^^^^ function or associated item not found in `SinsemillaChipOptimized<Hash, Commit, Fixed>`
   |
  ::: halo2_gadgets/src/sinsemilla_opt/chip.rs:30:1
   |
30 | pub struct SinsemillaChipOptimized<Hash, Commit, Fixed>
   | ------------------------------------------------------- function or associated item `check_hash_result` not found for this struct
   |
note: if you're trying to build a new `sinsemilla_opt::chip::SinsemillaChipOptimized<Hash, Commit, Fixed>`, consider using `sinsemilla_opt::chip::SinsemillaChipOptimized::<Hash, Commit, F>::construct` which returns `sinsemilla_opt::chip::SinsemillaChipOptimized<_, _, _>`
  --> halo2_gadgets/src/sinsemilla_opt/chip.rs:65:5
   |
65 |     pub fn construct(config: <Self as Chip<pallas::Base>>::Config) -> Self {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 614 in halo2_gadgets/src/sinsemilla.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

struct takes 4 generic arguments but 3 generic arguments were supplied 

error[E0107]: struct takes 4 generic arguments but 3 generic arguments were supplied
   --> halo2_gadgets/src/sinsemilla.rs:614:13
    |
614 |             SinsemillaChip::<TestHashDomain, TestCommitDomain, TestFixedBases>::load(
    |             ^^^^^^^^^^^^^^   --------------  ----------------  -------------- supplied 3 generic arguments
    |             |
    |             expected 4 generic arguments
    |
note: struct defined here, with 4 generic parameters: `Hash`, `Commit`, `Fixed`, `Lookup`
   --> halo2_gadgets/src/sinsemilla/chip.rs:111:12
    |
111 | pub struct SinsemillaChip<Hash, Commit, Fixed, Lookup>
    |            ^^^^^^^^^^^^^^ ----  ------  -----  ------
help: add missing generic argument
    |
614 |             SinsemillaChip::<TestHashDomain, TestCommitDomain, TestFixedBases, Lookup>::load(
    |                                                                              ++++++++

Check failure on line 583 in halo2_gadgets/src/sinsemilla.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

struct takes 2 generic arguments but 1 generic argument was supplied 

error[E0107]: struct takes 2 generic arguments but 1 generic argument was supplied
   --> halo2_gadgets/src/sinsemilla.rs:583:17
    |
583 |                 EccChip::<TestFixedBases>::configure(meta, advices, lagrange_coeffs, range_check);
    |                 ^^^^^^^   -------------- supplied 1 generic argument
    |                 |
    |                 expected 2 generic arguments
    |
note: struct defined here, with 2 generic parameters: `FixedPoints`, `LookupRangeCheckConfig`
   --> halo2_gadgets/src/ecc/chip.rs:230:12
    |
230 | pub struct EccChip<
    |            ^^^^^^^
231 |     FixedPoints: super::FixedPoints<pallas::Affine>,
    |     -----------
232 |     LookupRangeCheckConfig: DefaultLookupRangeCheck,
    |     ----------------------
help: add missing generic argument
    |
583 |                 EccChip::<TestFixedBases, LookupRangeCheckConfig>::configure(meta, advices, lagrange_coeffs, range_check);
    |                                         ++++++++++++++++++++++++

Check failure on line 286 in halo2_gadgets/src/sinsemilla/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

struct takes 4 generic arguments but 3 generic arguments were supplied 

error[E0107]: struct takes 4 generic arguments but 3 generic arguments were supplied
   --> halo2_gadgets/src/sinsemilla/merkle.rs:286:13
    |
286 |             SinsemillaChip::<TestHashDomain, TestCommitDomain, TestFixedBases>::load(
    |             ^^^^^^^^^^^^^^   --------------  ----------------  -------------- supplied 3 generic arguments
    |             |
    |             expected 4 generic arguments
    |
note: struct defined here, with 4 generic parameters: `Hash`, `Commit`, `Fixed`, `Lookup`
   --> halo2_gadgets/src/sinsemilla/chip.rs:111:12
    |
111 | pub struct SinsemillaChip<Hash, Commit, Fixed, Lookup>
    |            ^^^^^^^^^^^^^^ ----  ------  -----  ------
help: add missing generic argument
    |
286 |             SinsemillaChip::<TestHashDomain, TestCommitDomain, TestFixedBases, Lookup>::load(
    |                                                                              ++++++++

Check failure on line 275 in halo2_gadgets/src/sinsemilla/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: sinsemilla::SinsemillaInstructions<pasta_curves::EpAffine, 10, 253>` is not satisfied 

error[E0277]: the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: sinsemilla::SinsemillaInstructions<pasta_curves::EpAffine, 10, 253>` is not satisfied
   --> halo2_gadgets/src/sinsemilla/merkle.rs:275:27
    |
275 |             let config2 = MerkleChip::configure(meta, sinsemilla_config_2);
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `sinsemilla::SinsemillaInstructions<pasta_curves::EpAffine, 10, 253>` is not implemented for `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>`
    |
    = help: the following other types implement trait `sinsemilla::SinsemillaInstructions<C, K, MAX_WORDS>`:
              sinsemilla::chip::SinsemillaChip<Hash, Commit, F, LookupRangeCheckConfig>
              sinsemilla::merkle::chip::MerkleChip<SinsemillaChip>
              sinsemilla_opt::chip::SinsemillaChipOptimized<Hash, Commit, F>
note: required by a bound in `sinsemilla::merkle::chip::MerkleConfig`
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:30:11
    |
27  | pub struct MerkleConfig<SinsemillaChip>
    |            ------------ required by a bound in this struct
...
30  |         + SinsemillaInstructions<pallas::Affine, { sinsemilla::K }, { sinsemilla::C }>,
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `MerkleConfig`

Check failure on line 275 in halo2_gadgets/src/sinsemilla/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: halo2_proofs::circuit::Chip<pasta_curves::Fp>` is not satisfied 

error[E0277]: the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: halo2_proofs::circuit::Chip<pasta_curves::Fp>` is not satisfied
   --> halo2_gadgets/src/sinsemilla/merkle.rs:275:27
    |
275 |             let config2 = MerkleChip::configure(meta, sinsemilla_config_2);
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `halo2_proofs::circuit::Chip<pasta_curves::Fp>` is not implemented for `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>`
    |
    = help: the following other types implement trait `halo2_proofs::circuit::Chip<F>`:
              <ecc::chip::EccChip<FixedPoints, LookupRangeCheckConfig> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <poseidon::pow5::Pow5Chip<F, WIDTH, RATE> as halo2_proofs::circuit::Chip<F>>
              <sha256::table16::Table16Chip as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <sinsemilla::chip::SinsemillaChip<Hash, Commit, Fixed, LookupRangeCheckConfig> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <sinsemilla::merkle::chip::MerkleChip<SinsemillaChip> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <sinsemilla_opt::chip::SinsemillaChipOptimized<Hash, Commit, Fixed> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <utilities::cond_swap::CondSwapChip<F> as halo2_proofs::circuit::Chip<F>>
note: required by a bound in `sinsemilla::merkle::chip::MerkleConfig`
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:29:21
    |
27  | pub struct MerkleConfig<SinsemillaChip>
    |            ------------ required by a bound in this struct
28  | where
29  |     SinsemillaChip: Chip<pallas::Base>
    |                     ^^^^^^^^^^^^^^^^^^ required by this bound in `MerkleConfig`

Check failure on line 275 in halo2_gadgets/src/sinsemilla/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: sinsemilla::SinsemillaInstructions<pasta_curves::EpAffine, 10, 253>` is not satisfied 

error[E0277]: the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: sinsemilla::SinsemillaInstructions<pasta_curves::EpAffine, 10, 253>` is not satisfied
   --> halo2_gadgets/src/sinsemilla/merkle.rs:275:55
    |
275 |             let config2 = MerkleChip::configure(meta, sinsemilla_config_2);
    |                           ---------------------       ^^^^^^^^^^^^^^^^^^^ the trait `sinsemilla::SinsemillaInstructions<pasta_curves::EpAffine, 10, 253>` is not implemented for `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>`
    |                           |
    |                           required by a bound introduced by this call
    |
    = help: the following other types implement trait `sinsemilla::SinsemillaInstructions<C, K, MAX_WORDS>`:
              sinsemilla::chip::SinsemillaChip<Hash, Commit, F, LookupRangeCheckConfig>
              sinsemilla::merkle::chip::MerkleChip<SinsemillaChip>
              sinsemilla_opt::chip::SinsemillaChipOptimized<Hash, Commit, F>
note: required by a bound in `sinsemilla::merkle::chip::MerkleChip::<SinsemillaChip>::configure`
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:77:11
    |
77  |         + SinsemillaInstructions<pallas::Affine, { sinsemilla::K }, { sinsemilla::C }>,
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `MerkleChip::<SinsemillaChip>::configure`
...
80  |     pub fn configure(
    |            --------- required by a bound in this associated function

Check failure on line 275 in halo2_gadgets/src/sinsemilla/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: halo2_proofs::circuit::Chip<pasta_curves::Fp>` is not satisfied 

error[E0277]: the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: halo2_proofs::circuit::Chip<pasta_curves::Fp>` is not satisfied
   --> halo2_gadgets/src/sinsemilla/merkle.rs:275:55
    |
275 |             let config2 = MerkleChip::configure(meta, sinsemilla_config_2);
    |                           ---------------------       ^^^^^^^^^^^^^^^^^^^ the trait `halo2_proofs::circuit::Chip<pasta_curves::Fp>` is not implemented for `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>`
    |                           |
    |                           required by a bound introduced by this call
    |
    = help: the following other types implement trait `halo2_proofs::circuit::Chip<F>`:
              <ecc::chip::EccChip<FixedPoints, LookupRangeCheckConfig> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <poseidon::pow5::Pow5Chip<F, WIDTH, RATE> as halo2_proofs::circuit::Chip<F>>
              <sha256::table16::Table16Chip as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <sinsemilla::chip::SinsemillaChip<Hash, Commit, Fixed, LookupRangeCheckConfig> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <sinsemilla::merkle::chip::MerkleChip<SinsemillaChip> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <sinsemilla_opt::chip::SinsemillaChipOptimized<Hash, Commit, Fixed> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <utilities::cond_swap::CondSwapChip<F> as halo2_proofs::circuit::Chip<F>>
note: required by a bound in `sinsemilla::merkle::chip::MerkleChip::<SinsemillaChip>::configure`
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:76:21
    |
76  |     SinsemillaChip: Chip<pallas::Base>
    |                     ^^^^^^^^^^^^^^^^^^ required by this bound in `MerkleChip::<SinsemillaChip>::configure`
...
80  |     pub fn configure(
    |            --------- required by a bound in this associated function

Check failure on line 265 in halo2_gadgets/src/sinsemilla/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: sinsemilla::SinsemillaInstructions<pasta_curves::EpAffine, 10, 253>` is not satisfied 

error[E0277]: the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: sinsemilla::SinsemillaInstructions<pasta_curves::EpAffine, 10, 253>` is not satisfied
   --> halo2_gadgets/src/sinsemilla/merkle.rs:265:27
    |
265 |             let config1 = MerkleChip::configure(meta, sinsemilla_config_1);
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `sinsemilla::SinsemillaInstructions<pasta_curves::EpAffine, 10, 253>` is not implemented for `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>`
    |
    = help: the following other types implement trait `sinsemilla::SinsemillaInstructions<C, K, MAX_WORDS>`:
              sinsemilla::chip::SinsemillaChip<Hash, Commit, F, LookupRangeCheckConfig>
              sinsemilla::merkle::chip::MerkleChip<SinsemillaChip>
              sinsemilla_opt::chip::SinsemillaChipOptimized<Hash, Commit, F>
note: required by a bound in `sinsemilla::merkle::chip::MerkleConfig`
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:30:11
    |
27  | pub struct MerkleConfig<SinsemillaChip>
    |            ------------ required by a bound in this struct
...
30  |         + SinsemillaInstructions<pallas::Affine, { sinsemilla::K }, { sinsemilla::C }>,
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `MerkleConfig`

Check failure on line 265 in halo2_gadgets/src/sinsemilla/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: halo2_proofs::circuit::Chip<pasta_curves::Fp>` is not satisfied 

error[E0277]: the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: halo2_proofs::circuit::Chip<pasta_curves::Fp>` is not satisfied
   --> halo2_gadgets/src/sinsemilla/merkle.rs:265:27
    |
265 |             let config1 = MerkleChip::configure(meta, sinsemilla_config_1);
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `halo2_proofs::circuit::Chip<pasta_curves::Fp>` is not implemented for `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>`
    |
    = help: the following other types implement trait `halo2_proofs::circuit::Chip<F>`:
              <ecc::chip::EccChip<FixedPoints, LookupRangeCheckConfig> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <poseidon::pow5::Pow5Chip<F, WIDTH, RATE> as halo2_proofs::circuit::Chip<F>>
              <sha256::table16::Table16Chip as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <sinsemilla::chip::SinsemillaChip<Hash, Commit, Fixed, LookupRangeCheckConfig> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <sinsemilla::merkle::chip::MerkleChip<SinsemillaChip> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <sinsemilla_opt::chip::SinsemillaChipOptimized<Hash, Commit, Fixed> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <utilities::cond_swap::CondSwapChip<F> as halo2_proofs::circuit::Chip<F>>
note: required by a bound in `sinsemilla::merkle::chip::MerkleConfig`
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:29:21
    |
27  | pub struct MerkleConfig<SinsemillaChip>
    |            ------------ required by a bound in this struct
28  | where
29  |     SinsemillaChip: Chip<pallas::Base>
    |                     ^^^^^^^^^^^^^^^^^^ required by this bound in `MerkleConfig`

Check failure on line 265 in halo2_gadgets/src/sinsemilla/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: sinsemilla::SinsemillaInstructions<pasta_curves::EpAffine, 10, 253>` is not satisfied 

error[E0277]: the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: sinsemilla::SinsemillaInstructions<pasta_curves::EpAffine, 10, 253>` is not satisfied
   --> halo2_gadgets/src/sinsemilla/merkle.rs:265:55
    |
265 |             let config1 = MerkleChip::configure(meta, sinsemilla_config_1);
    |                           ---------------------       ^^^^^^^^^^^^^^^^^^^ the trait `sinsemilla::SinsemillaInstructions<pasta_curves::EpAffine, 10, 253>` is not implemented for `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>`
    |                           |
    |                           required by a bound introduced by this call
    |
    = help: the following other types implement trait `sinsemilla::SinsemillaInstructions<C, K, MAX_WORDS>`:
              sinsemilla::chip::SinsemillaChip<Hash, Commit, F, LookupRangeCheckConfig>
              sinsemilla::merkle::chip::MerkleChip<SinsemillaChip>
              sinsemilla_opt::chip::SinsemillaChipOptimized<Hash, Commit, F>
note: required by a bound in `sinsemilla::merkle::chip::MerkleChip::<SinsemillaChip>::configure`
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:77:11
    |
77  |         + SinsemillaInstructions<pallas::Affine, { sinsemilla::K }, { sinsemilla::C }>,
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `MerkleChip::<SinsemillaChip>::configure`
...
80  |     pub fn configure(
    |            --------- required by a bound in this associated function

Check failure on line 265 in halo2_gadgets/src/sinsemilla/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: halo2_proofs::circuit::Chip<pasta_curves::Fp>` is not satisfied 

error[E0277]: the trait bound `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>: halo2_proofs::circuit::Chip<pasta_curves::Fp>` is not satisfied
   --> halo2_gadgets/src/sinsemilla/merkle.rs:265:55
    |
265 |             let config1 = MerkleChip::configure(meta, sinsemilla_config_1);
    |                           ---------------------       ^^^^^^^^^^^^^^^^^^^ the trait `halo2_proofs::circuit::Chip<pasta_curves::Fp>` is not implemented for `sinsemilla::chip::SinsemillaConfig<_, _, _, utilities::lookup_range_check::LookupRangeCheckConfig<pasta_curves::Fp, 10>>`
    |                           |
    |                           required by a bound introduced by this call
    |
    = help: the following other types implement trait `halo2_proofs::circuit::Chip<F>`:
              <ecc::chip::EccChip<FixedPoints, LookupRangeCheckConfig> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <poseidon::pow5::Pow5Chip<F, WIDTH, RATE> as halo2_proofs::circuit::Chip<F>>
              <sha256::table16::Table16Chip as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <sinsemilla::chip::SinsemillaChip<Hash, Commit, Fixed, LookupRangeCheckConfig> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <sinsemilla::merkle::chip::MerkleChip<SinsemillaChip> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <sinsemilla_opt::chip::SinsemillaChipOptimized<Hash, Commit, Fixed> as halo2_proofs::circuit::Chip<pasta_curves::Fp>>
              <utilities::cond_swap::CondSwapChip<F> as halo2_proofs::circuit::Chip<F>>
note: required by a bound in `sinsemilla::merkle::chip::MerkleChip::<SinsemillaChip>::configure`
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:76:21
    |
76  |     SinsemillaChip: Chip<pallas::Base>
    |                     ^^^^^^^^^^^^^^^^^^ required by this bound in `MerkleChip::<SinsemillaChip>::configure`
...
80  |     pub fn configure(
    |            --------- required by a bound in this associated function

Check failure on line 511 in halo2_gadgets/src/sinsemilla/merkle/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

no field `sinsemilla_chip` on type `&sinsemilla::merkle::chip::MerkleChip<SinsemillaChip>` 

error[E0609]: no field `sinsemilla_chip` on type `&sinsemilla::merkle::chip::MerkleChip<SinsemillaChip>`
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:511:14
    |
511 |         self.sinsemilla_chip.hash_to_point(layouter, Q, message)
    |              ^^^^^^^^^^^^^^^ unknown field
    |
help: one of the expressions' fields has a field of the same name
    |
511 |         self.config.sinsemilla_chip.hash_to_point(layouter, Q, message)
    |              +++++++

Check failure on line 510 in halo2_gadgets/src/sinsemilla/merkle/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

no field `sinsemilla_config` on type `&sinsemilla::merkle::chip::MerkleConfig<SinsemillaChip>` 

error[E0609]: no field `sinsemilla_config` on type `&sinsemilla::merkle::chip::MerkleConfig<SinsemillaChip>`
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:510:36
    |
510 |         let config = self.config().sinsemilla_config.clone();
    |                                    ^^^^^^^^^^^^^^^^^ unknown field
    |
help: a field with a similar name exists
    |
510 |         let config = self.config().sinsemilla_chip.clone();
    |                                    ~~~~~~~~~~~~~~~

Check failure on line 498 in halo2_gadgets/src/sinsemilla/merkle/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

no field `sinsemilla_chip` on type `&sinsemilla::merkle::chip::MerkleChip<SinsemillaChip>` 

error[E0609]: no field `sinsemilla_chip` on type `&sinsemilla::merkle::chip::MerkleChip<SinsemillaChip>`
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:498:14
    |
498 |         self.sinsemilla_chip
    |              ^^^^^^^^^^^^^^^ unknown field
    |
help: one of the expressions' fields has a field of the same name
    |
498 |         self.config.sinsemilla_chip
    |              +++++++

Check failure on line 497 in halo2_gadgets/src/sinsemilla/merkle/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

no field `sinsemilla_config` on type `&sinsemilla::merkle::chip::MerkleConfig<SinsemillaChip>` 

error[E0609]: no field `sinsemilla_config` on type `&sinsemilla::merkle::chip::MerkleConfig<SinsemillaChip>`
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:497:36
    |
497 |         let config = self.config().sinsemilla_config.clone();
    |                                    ^^^^^^^^^^^^^^^^^ unknown field
    |
help: a field with a similar name exists
    |
497 |         let config = self.config().sinsemilla_chip.clone();
    |                                    ~~~~~~~~~~~~~~~
View more details on GitHub Actions