Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a QML folder and a tutorial guidelines file #8

Merged
merged 9 commits into from
Jun 20, 2020

Conversation

SashwatAnagolum
Copy link
Member

@SashwatAnagolum SashwatAnagolum commented Jun 8, 2020

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • The commit message is descriptive enough to convey what you are trying to contribute.
  • What kind of change does this PR introduce? (Is it a new learning resource, tutorial or something else?)

Created a tutorial guidelines file, and a quantum machine learning resource folder.

@SashwatAnagolum
Copy link
Member Author

The QML file is still very skeletal, definitely needs more stuff, as well as descriptions of each link, but I think this is a good starting point.

Copy link
Member

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greating starting point!

@MadhavJivrajani
Copy link
Member

MadhavJivrajani commented Jun 8, 2020

@SashwatAnagolum We need to keep the naming of the folders uniform, so since its only meant for resources, maybe name it Quantum Machine Learning instead of quantumMachineLearning, just for the sake of increased readability.

Copy link
Member

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Maybe add an explicit link to the qiksit textbook's section on single-qubit gates or more specifically Ry and controlled gates.

Also, try adding a cell that gives the output of qc.draw() to show the circuit constructed.

@MadhavJivrajani MadhavJivrajani merged commit 8a73255 into QForestCommunity:master Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants