Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from UTC Sheffield's Algorave Club #270

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

stretchyboy
Copy link

Trying to tidy up contributions for students, but made error and struggling to do them separately
.
4305ee4 & 90566b1 Add PBase a which takes a number converts it into a base (2 for binary by default) and splits it into a pattern of the digits. Useful for degrees or rhythms from a number

We use NixOS at school so c9c7a8e makes FoxDot compatible with that

c9c7a8e & 8ae8b0f add soloBars and soloBeats which allow for the DJ trick of soloing instrument(s) for a few beats / bars and bringing everything back in.

b376c77 just fixes a weird use of "is"

dffb7eb adds Pattern.bubble_sort and shell sort which take a pattern and stage by stage sort it to extend the pattern

Ethan-Dowdall and others added 7 commits December 28, 2024 17:57
Returns the 'n' number in base 'b' split into digits.
 e.g. `PBase(5)` will return `P[1,0,1]`
 and  `PBase(5,4)` will return `P[1,1]`
 and  `PBase(5,4,4)` will return `P[0,0,1,1]`
to Players and Groups to emulate a technique that CCAI use live.
Dropping to only the drums for a bar or 2 before kicking back in.
Clem does this manually
Adds @group_method decorator to allow this
So what you have soloed will end at the end of the solo

d2 >> play("X").soloBars(end=True)
l_all.soloBeats(12, True)
while(len(number_list) < l):
number_list.insert(0, 0)

#print("from_10_to_anybase("+str(num)+","+str(base)+")", number_list)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @stretchyboy would you mind doing a quick pass on some of the commented out prints and I can merge this in?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi I assume you mean delete them / tidy up? Can I do that in the pull request or do I do another?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's possible to do that in this pull request, that would be great - thanks!

@@ -0,0 +1,18 @@
{ lib, pkgs ? import <nixpkgs> { } }:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I/we add comments to these files to specify they're required for NixOS?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to ask my NixOS guru on Monday



@group_method
def soloBars_group(self,n=2, end=False):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add these to the Group class itself and also add in the clock there. Would that work for you?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, can't remember why it ended up there in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants