Don't validate rzz angle for non-fixed parameters #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rzz validation check was using `CircuitInstruction.params`, an alias for `CircuitInstruction.operation.params` added in Qiskit 1.2. Here the usage is replaced `CircuitInstruction.operation.params` to keep compatibility with Qiskit 1.1.
…ntime into rzzparam
This was referenced Oct 28, 2024
ihincks
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1998. Based on (therefore includes) #1986.
Details and comments
Here we only skip the validation if the angle is of type
Parameter. One could expect that, if the angle is aParameter, then we should verify that all values assigned to the parameter are in the permitted range. Let's discuss it in the issue.No release notes because rzz gates are have not been released yet.