Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pip install qiskit-ibm-runtime[visualization] #2003

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Allow pip install qiskit-ibm-runtime[visualization] #2003

merged 1 commit into from
Oct 30, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Oct 29, 2024 •
edited
Loading

Summary

Details and comments

Fixes #1997

ihincks
ihincks reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@ihincks ihincks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Would it be possible to set REQUIREMENTS and REQUIREMENTS_VIS to be read in from requirements.txt and requirements-visualization.txt to avoid sync issues? Here or another PR.

@kt474
Copy link
Member Author

kt474 commented Oct 30, 2024

Would it be possible to set REQUIREMENTS and REQUIREMENTS_VIS to be read in from requirements.txt and requirements-visualization.txt to avoid sync issues? Here or another PR.

Let's discuss/handle this in a separate PR. Seems like the general consensus is that pulling the dependencies from requirements.txt into setup.py is not the best idea.

@kt474 kt474 merged commit 69f615b into Qiskit:main Oct 30, 2024
19 checks passed
@kt474 kt474 deleted the add-visualization-install branch October 30, 2024 19:00
@kt474 kt474 mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihincks ihincks ihincks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot install qiskit-ibm-runtime[visualization] from pypi
2 participants
@kt474 @ihincks