Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qiskit 2.0 Compatibility #2116

Merged
merged 27 commits into from
Mar 13, 2025
Merged

Qiskit 2.0 Compatibility #2116

merged 27 commits into from
Mar 13, 2025

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Jan 27, 2025

Summary

Since support for pulse gates is being sunset, the Channel related imports and code have been removed:

Non pulse related:

Without Channel, PulseDefaults are no longer needed for the backend target.

I'll handle the DD related pulse deprecations in a separate PR. Also we should clean up a lot of the backend defaults code since it will no longer be necessary.

Details and comments

Fixes #

@kt474 kt474 changed the title Qiskit Deprecations Qiskit 1.3 deprecation pulse removals Feb 3, 2025
@kt474 kt474 marked this pull request as ready for review February 3, 2025 19:29
@kt474 kt474 changed the title Qiskit 1.3 deprecation pulse removals Qiskit 1.3 deprecation pulse gate removals Feb 6, 2025
@wshanks
Copy link
Collaborator

wshanks commented Feb 28, 2025

Perhaps all the defs_*.json files for the fake backends should also be deleted in this PR?

@kt474 kt474 added this to the 0.37.0 milestone Mar 5, 2025
@wshanks
Copy link
Collaborator

wshanks commented Mar 11, 2025

I think I tested with a build of Qiskit 2.0 before Qiskit/qiskit#13860 was merged so I missed the qiskit.circuit.bit issue. I think the other things you highlighted (besides the docstring) are addressed in #2162 @eliarbel

@eliarbel
Copy link
Collaborator

I think the other things you highlighted (besides the docstring) are addressed in #2162 @eliarbel

You're right @wshanks . I only noticed #2162 after I reviewed this PR though :-)

@kt474 kt474 changed the title Qiskit 1.3 deprecation pulse gate removals Qiskit 2.0 Compatibility Mar 11, 2025
@kt474
Copy link
Member Author

kt474 commented Mar 11, 2025

Addressed all comments and merged #2161 into this branch.

Passes all unit tests against Qiskit 2.0rc1 except the qiskit-aer import issues in the Neat tests which will be fixed in Qiskit/qiskit-aer#2327 (so we'll need a release on the aer side too).

@kt474 kt474 requested a review from eliarbel March 11, 2025 18:08
Copy link
Collaborator

@eliarbel eliarbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kt474 for addressing the previous comments and putting this all together in a single PR, it helps!
I've left some more requests for changes and questions in line.

Copy link
Collaborator

@wshanks wshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of PulseBackendConfiguration looks good except for one small thing.

Copy link
Collaborator

@eliarbel eliarbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM now given the clarification from Jessie about IBMBackend API and the removal of PulseBackendConfiguration.
There are still a few removed tests in test_schedulers.py which could be kept but I don't think worth blocking this PR on at this stage.

@ElePT
Copy link
Collaborator

ElePT commented Mar 13, 2025

Addressed all comments and merged #2161 into this branch.

Passes all unit tests against Qiskit 2.0rc1 except the qiskit-aer import issues in the Neat tests which will be fixed in Qiskit/qiskit-aer#2327 (so we'll need a release on the aer side too).

Qiskit/qiskit-aer#2327 is included in the latest release of Aer that just came out: qiskit-aer 0.17.0.

@kt474
Copy link
Member Author

kt474 commented Mar 13, 2025

Qiskit/qiskit-aer#2327 is included in the latest release of Aer that just came out: qiskit-aer 0.17.0.

All unit tests passing on both Qiskit 1.4.1 and 2.0rc1 with the latest aer release. Going to merge now, other bugs found will be handled in separate PRs.

@kt474 kt474 merged commit 1fee3d6 into Qiskit:main Mar 13, 2025
17 checks passed
@kt474 kt474 deleted the qiskit-1.3-removals branch March 13, 2025 15:00
@kt474 kt474 added Changelog: New Feature Include in the Added section of the changelog Changelog: Removal Include in the Removed section of the changelog labels Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the Added section of the changelog Changelog: Removal Include in the Removed section of the changelog Qiskit 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants