-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qiskit 2.0 Compatibility #2116
Qiskit 2.0 Compatibility #2116
Conversation
Perhaps all the |
I think I tested with a build of Qiskit 2.0 before Qiskit/qiskit#13860 was merged so I missed the |
Addressed all comments and merged #2161 into this branch. Passes all unit tests against Qiskit 2.0rc1 except the qiskit-aer import issues in the Neat tests which will be fixed in Qiskit/qiskit-aer#2327 (so we'll need a release on the aer side too). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kt474 for addressing the previous comments and putting this all together in a single PR, it helps!
I've left some more requests for changes and questions in line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of PulseBackendConfiguration
looks good except for one small thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM now given the clarification from Jessie about IBMBackend
API and the removal of PulseBackendConfiguration
.
There are still a few removed tests in test_schedulers.py
which could be kept but I don't think worth blocking this PR on at this stage.
Qiskit/qiskit-aer#2327 is included in the latest release of Aer that just came out: |
All unit tests passing on both Qiskit 1.4.1 and 2.0rc1 with the latest aer release. Going to merge now, other bugs found will be handled in separate PRs. |
Summary
Since support for pulse gates is being sunset, the
Channel
related imports and code have been removed:fake_backend.py
:AcquireChannel
,DriveChannel
,MeasureChannel
,ControlChannel
backend_configuration.py
:AcquireChannel
,Channel
,ControlChannel
,DriveChannel
,MeasureChannel
ibm_backend.py
:AcquireChannel
,ControlChannel
,DriveChannel
,MeasureChannel
pulse_defaults.py
:InstructionScheduleMap
andPulseQobjDef
.PulseBackendConfiguration
has been removed, all backend configurations will be returned asQasmBackendConfiguration
.c_if
andcondition_bit
removed in Remove condition/c_if, duration, and unit from instructions qiskit#13506has_calibration_for
andcalibrations
removed in Remove calibrations APIs and related functionality qiskit#13861Non pulse related:
qiskit.circuit.bit
removed in MoveBit
andRegister
to live in Rust space qiskit#13860EfficientSU2
has been replaced withefficient_su2
Without
Channel
,PulseDefaults
are no longer needed for the backend target.I'll handle the DD related pulse deprecations in a separate PR. Also we should clean up a lot of the backend defaults code since it will no longer be necessary.
Details and comments
Fixes #