Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle backend_props removal in PM plugins #2134

Merged
merged 6 commits into from
Mar 6, 2025

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Feb 10, 2025

Summary

backend_props was removed in Qiskit/qiskit#13706 causing our tests against qiskit main to fail.

Details and comments

Fixes #

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Qiskit 1.x series, it's required to keep passing on this argument, so it shouldn't be removed until the minimum requirement is Qiskit 2.0. If you want to support both, we should add the argument only if the Qiskit version is in the 1.x series, so something like:

if is_qiskit_1():
    legacy_options = {"backend_props": pass_manager_config.backend_properties}
else:
    legacy_options = {}
pm = generate_translation_passmanager(..., **legacy_options)

That said, the removal hasn't been handled very cleanly on the Qiskit side, and it's plausible it'll change a little before release.

@kt474 kt474 added this to the 0.37.0 milestone Mar 5, 2025
@kt474 kt474 changed the title Remove backend_props from PM plugins Handle backend_props removal in PM plugins Mar 6, 2025
@kt474 kt474 merged commit 3fbaa7e into Qiskit:main Mar 6, 2025
17 checks passed
@kt474 kt474 deleted the backend-props-removal branch March 6, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants