Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from setup.py to pyproject.toml #422

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

Eric-Arellano
Copy link
Collaborator

pyproject.toml is now the standardized way to set packaging metadata for Python packages. When possible, setuptools recommends using it rather than a dynamic setup.py time.

Switching to pyproject.toml specifically unblocks #419.

Another benefit is we can deduplicate setting the version in two places.

Gets rid of "universal" wheel

We were incorrectly claiming in setup.cfg that the package is "universal", which means it works with both Python 2 and Python 3. That is a lie. We don't support Python 2.

Copy link
Collaborator

@javabster javabster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Eric-Arellano Eric-Arellano merged commit 4549f2c into Qiskit:main Jun 27, 2023
@Eric-Arellano Eric-Arellano deleted the pyproject-toml branch June 27, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants