Skip to content

Commit

Permalink
Set files-changed-only and format-review to false.
Browse files Browse the repository at this point in the history
If we expect some of our PRs to have a large diff, then we should disable any features that rely on having diff information:
- lines-changed-only,
- files-changed-only,
- format-review, and
- tidy-review.

For a more detailed explanation: cpp-linter/cpp-linter-action#274 (comment)
  • Loading branch information
rturrado committed Oct 18, 2024
1 parent aa8cea6 commit 9c29ee2
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/linters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
extensions: 'cpp,hpp'
files-changed-only: 'true'
format-review: 'true'
style: 'file' # use .clang-format config file
tidy-checks: '-*' # disable clang-tidy checks
version: 18
Expand Down

0 comments on commit 9c29ee2

Please sign in to comment.