refactor: replaces the math functions with float based function from the standard namespace
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![deepsource-autofix[bot]](https://avatars.githubusercontent.com/in/57168?s=60&v=4){kind=small}
…m the standard namespace Calling math functions from the C libray that only accept `double` with `float` arguments causes an implicit type promotion of the `float` argument. Type promoting `float` to `double` costs extra space in memory, it also costs extra instructions for the conversion from `float` and lastly vectorisation of `float` is a lot more efficient compared to `double`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling math functions from the C libray that only accept
doublewithfloatarguments causes an implicit type promotion of thefloatargument. Type promotingfloattodoublecosts extra space in memory, it also costs extra instructions for the conversion fromfloatand lastly vectorisation offloatis a lot more efficient compared todouble.