Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement flexible slicing in methylation probe mapping #14

Open
katehoffshutta opened this issue Dec 6, 2022 · 2 comments
Open

Implement flexible slicing in methylation probe mapping #14

katehoffshutta opened this issue Dec 6, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@katehoffshutta
Copy link
Collaborator

In mapProbesToGenes, the options for slicing are rangeUp and rangeDown, indicating how far up and down from the TSS to search. Both have to be non-negative numbers. It would be good to fix this so a user can slice regions that don't include the TSS (e.g., -1500 to -200bp).

@soelmicheletti soelmicheletti self-assigned this Aug 24, 2023
@soelmicheletti
Copy link
Collaborator

Before I implement this I have a question.

In the manifest there is "probe_strand"="+" (and possibly, I guess, "probe_strand"="-"). However, we don't look at it in our implementation.

I remember that Jonas explained me that based on strand, the genome is read in a certain direction. Shouldn't we switch rangeUp and rangeDown based on this?

@katehoffshutta
Copy link
Collaborator Author

Good catch, Soel. So, rangeUp and rangeDown interact with the distToTSS column in the manifest, which I believe Jonas checked is calculated based on strand, so -200 means 200 base pairs upstream, whether on the + or - strand. However, it would be great to spot check this using the genome browser on a few rows of the manifest to make sure we are correct.

@katehoffshutta katehoffshutta added the enhancement New feature or request label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants