-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gene map ensembl ids are transcripts probeToMeanPromoterMethylation #27
Comments
This behavior actually comes from the generation of the probe map in |
I see your point, but this is problematic for most downstream applications (including everything we do), as we work on a gene-level (i.e., reference genome annotation) and not transcript-level. Then the question becomes, how do we map from the transcripts to genome-level? Also, these methylation counts are a genomic feature and not mRNA feature. There is reasoning for both ways, but we should decide and keep it consistent for practicality -- and if we stick to transcript-level promoter definitions we should warn users and provide a function to map to the genome. |
Based on the manifest use of transcripts vs. genes, I propose this resolution @FischerJoBio:
I don't think we need to provide a function to map to the genome at this point, but we could open it as a separate issue for enhancement if desired. |
Note that when we do the mapping in
|
The returned Ensembl ids of the probe map of
probeToMeanPromoterMethylation
are transcripts (ENST*) but should be genes (ENSG*), as probes are mapped to the genome and not transcript-level informationThe text was updated successfully, but these errors were encountered: