Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests and small refactoring to avoid duplicate code #5

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

arodus
Copy link
Contributor

@arodus arodus commented Oct 31, 2023

Description

Not all tests were running properly, this PR fixes the issue and refactors the tests so less duplicated code is being used.
The classes could be renamed as the different brokerages are not existing anymore but they're still testing the different categories and I didn't have a better idea for a name.

Related Issue

Part of QuantConnect/Lean#5898

Motivation and Context

Failing tests

Requires Documentation Change

How Has This Been Tested?

Running the tests
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@arodus arodus mentioned this pull request Oct 31, 2023
11 tasks
Copy link
Contributor

@jhonabreul jhonabreul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ty! Leaving a few minor comments

@arodus arodus requested a review from jhonabreul November 3, 2023 14:27
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎸

@Martin-Molinero Martin-Molinero merged commit 2ec4892 into QuantConnect:master Nov 6, 2023
@arodus arodus deleted the bug-fix-tests branch November 6, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants