Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keras lecture first build #196

Merged
merged 7 commits into from
Nov 19, 2024
Merged

keras lecture first build #196

merged 7 commits into from
Nov 19, 2024

Conversation

jstac
Copy link
Contributor

@jstac jstac commented Nov 18, 2024

No description provided.

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for incomparable-parfait-2417f8 ready!

Name Link
🔨 Latest commit c7b982b
🔍 Latest deploy log https://app.netlify.com/sites/incomparable-parfait-2417f8/deploys/673c307a3af09600085f9116
😎 Deploy Preview https://deploy-preview-196--incomparable-parfait-2417f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 18, 2024

@github-actions github-actions bot temporarily deployed to pull request November 18, 2024 23:52 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 18, 2024 23:54 Inactive
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstac this is a really neat lecture.

I only have minor fixes / comments (see suggestions)

The loss figures look very similar upon casual inspection, however the y-axis scales are very different, perhaps you could have the same y-axis and plot the Epoch (x-axis) to 500 or so. Just a thought.

The first implements linear regression.

This is achieved by constructing a neural network with just one layer, that maps
to a single dimension (since the prediction
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstac this parentheses is incomplete.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmcky , that was meant to be "(since the prediction is real-valued)"

lectures/keras.md Outdated Show resolved Hide resolved
lectures/keras.md Outdated Show resolved Hide resolved
@mmcky
Copy link
Contributor

mmcky commented Nov 19, 2024

@jstac I merged the trivial comments. Not sure what you intended to be in the parenthesis to complete. If you git pull and update then I'll merge and make live.

@github-actions github-actions bot temporarily deployed to pull request November 19, 2024 02:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 19, 2024 02:51 Inactive
@jstac
Copy link
Contributor Author

jstac commented Nov 19, 2024

Thanks @mmcky , please make that small change above completing the sentence, make any improvements you like to the figures (or skip if you're busy) and then make it live.

@mmcky
Copy link
Contributor

mmcky commented Nov 19, 2024

thanks @jstac I will make that change and make this live.

@github-actions github-actions bot temporarily deployed to pull request November 19, 2024 06:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 19, 2024 06:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 19, 2024 06:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 19, 2024 06:38 Inactive
@mmcky mmcky merged commit 14b6ace into main Nov 19, 2024
7 checks passed
@mmcky mmcky deleted the add_keras branch November 19, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants