Apply suggestions from code review

Co-authored-by: Kevin Klein <[email protected]>
Quantco · Jul 22, 2024 · 4c1c12d · 4c1c12d
1 parent 7c16b02
commit 4c1c12d
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/metalearners/grid_search.py b/metalearners/grid_search.py
@@ -348,7 +348,7 @@ def fit(
 
         self.grid_size_ = len(jobs)
         self.raw_results_: list[GSResult] | Generator[GSResult, None, None] | None
-        self.results_: pd.DataFrame | None
+        self.results_: pd.DataFrame | None = None
 
         return_as = "list" if self.store_raw_results else "generator_unordered"
         parallel = Parallel(
@@ -360,5 +360,3 @@ def fit(
             if not self.store_raw_results:
                 # The generator will be empty so we replace it with None
                 self.raw_results_ = None
-        else:
-            self.results_ = None