Warn instead of raising an error if SLearner is given feature_set (…

…#16)

CHANGELOG.rst

@@ -7,6 +7,11 @@
 Changelog
 =========
 
+0.5.0 (2024-06-18)
+------------------
+
+* No longer raise an error if ``feature_set`` is provided to :class:`metalearners.SLearner`.
+
 0.4.2 (2024-06-18)
 ------------------
 

metalearners/slearner.py

@@ -93,7 +93,10 @@ def _validate_params(self, feature_set, **kwargs):
             # For SLearner it does not make sense to allow feature set as we only have one model
             # and having it would bring problems when using fit_nuisance and predict_nuisance
             # as we need to add the treatment column.
-            raise ValueError("SLearner does not support feature set definition.")
+            warnings.warn(
+                "Base-model specific feature_sets were provided to S-Learner. "
+                "These will be ignored and all available features will be used instead."
+            )
 
     def fit(
         self,

tests/test_slearner.py

@@ -10,16 +10,13 @@
 from metalearners.slearner import SLearner, _append_treatment_to_covariates
 
 
-def test_feature_set_raise():
-    with pytest.raises(
-        ValueError, match="SLearner does not support feature set definition."
-    ):
-        SLearner(
-            nuisance_model_factory=LinearRegression,
-            is_classification=False,
-            n_variants=2,
-            feature_set="",
-        )
+def test_feature_set_doesnt_raise():
+    SLearner(
+        nuisance_model_factory=LinearRegression,
+        is_classification=False,
+        n_variants=2,
+        feature_set="",
+    )
 
 
 @pytest.mark.parametrize(