-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to pixi #12
Migrate to pixi #12
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=======================================
Coverage 94.67% 94.67%
=======================================
Files 14 14
Lines 1295 1295
=======================================
Hits 1226 1226
Misses 69 69 ☔ View full report in Codecov by Sentry. |
FYI @DelongChenQC, @MatthiasLoefflerQC (couldn't find Arsenyi's GitHub handle) |
.github/workflows/ci.yml
Outdated
uses: quantco/pre-commit-conda@v1 | ||
environments: default lint | ||
- name: pre-commit | ||
run: pixi run pre-commit-run --color=always --show-diff-on-failure | ||
|
||
mypy-type-checks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When properly checking it in pre-commit (see other comment), we don't need this here as it's already being checked by the pre-commit hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed it!
Co-authored-by: Pavel Zwerschke <[email protected]>
Co-authored-by: Pavel Zwerschke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, I think it's important to add in the README how one can build the environment and the basics for development but maybe we can leave it for another PR.
The Windows tests are failing - I created an issue to follow up on it after this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Pavel Zwerschke <[email protected]>
I think that we should add a 'development' section in the docs as a follow-up to this PR; explaining how one can locally