Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for superset instead of set equality in _initialize_model_dict #15

Merged
merged 13 commits into from
Jun 18, 2024
Merged

Check for superset instead of set equality in _initialize_model_dict #15

merged 13 commits into from
Jun 18, 2024

Conversation

kklein
Copy link
Collaborator

@kklein kklein commented Jun 18, 2024 •
edited
Loading

Checklist

  • Added a CHANGELOG.rst entry

@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.67%. Comparing base (7f5a16d) to head (ab23a4e).
Report is 1 commits behind head on main.

❗ Current head ab23a4e differs from pull request most recent head 036c519

Please upload reports for the commit 036c519 to get more accurate results.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   94.67%   94.67%           
=======================================
  Files          14       14           
  Lines        1295     1295           
=======================================
  Hits         1226     1226           
  Misses         69       69

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kklein kklein marked this pull request as ready for review June 18, 2024 15:30
@kklein kklein changed the title Check for superset instead of set equality in _initialize_model_dict Check for superset instead of set equality in _initialize_model_dict Jun 18, 2024
@kklein kklein linked an issue Jun 18, 2024 that may be closed by this pull request
Model-specific intialization fails if a superset of expected base model keys is provided #13
Closed
kklein
kklein commented Jun 18, 2024
View reviewed changes
tests/test_metalearner.py Outdated Show resolved Hide resolved
@kklein kklein merged commit edad6bb into main Jun 18, 2024
6 checks passed
@kklein kklein deleted the fix_model_dict branch June 18, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model-specific intialization fails if a superset of expected base model keys is provided
1 participant
@kklein