Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optuna example #23

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Fix optuna example #23

merged 2 commits into from
Jun 24, 2024

Conversation

FrancescMartiEscofetQC
Copy link
Contributor

This PR fixes a variable name in the optuna example, reduces some verbose of models and it's reran to check that everything works fine.

Checklist

  • Added a CHANGELOG.rst entry

@FrancescMartiEscofetQC FrancescMartiEscofetQC marked this pull request as ready for review June 24, 2024 11:49
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.67%. Comparing base (049fbea) to head (bb036bc).
Report is 59 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   94.67%   94.67%           
=======================================
  Files          14       14           
  Lines        1295     1295           
=======================================
  Hits         1226     1226           
  Misses         69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kklein kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@FrancescMartiEscofetQC FrancescMartiEscofetQC merged commit 043a59e into main Jun 24, 2024
9 checks passed
@FrancescMartiEscofetQC FrancescMartiEscofetQC deleted the fix_optuna_example branch June 24, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants