Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename T to W in docs #36

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Rename T to W in docs #36

merged 5 commits into from
Jun 27, 2024

Conversation

kklein
Copy link
Collaborator

@kklein kklein commented Jun 27, 2024 •
edited
Loading

No description provided.

@kklein kklein changed the title Rename $T$ to $W$ in docs Rename T to W in docs Jun 27, 2024
@kklein kklein linked an issue Jun 27, 2024 that may be closed by this pull request
Consistently use W, rather than T, in docs #33
Closed
@kklein kklein marked this pull request as ready for review June 27, 2024 13:39
@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (ebc6aee) to head (6f61557).
Report is 47 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files          14       14           
  Lines        1365     1365           
=======================================
  Hits         1297     1297           
  Misses         68       68

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

FrancescMartiEscofetQC
FrancescMartiEscofetQC previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@FrancescMartiEscofetQC FrancescMartiEscofetQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
Just a nit, in the background section we have the residuals with \widetilde instead of \tilde, maybe we can do it also here so it is the same but feel free to ignore.
Screenshot 2024-06-27 at 15 42 26

@kklein
Copy link
Collaborator Author

kklein commented Jun 27, 2024

Nice catch :)

FrancescMartiEscofetQC
FrancescMartiEscofetQC approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@FrancescMartiEscofetQC FrancescMartiEscofetQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kklein kklein merged commit 778701c into main Jun 27, 2024
15 checks passed
@kklein kklein deleted the rename-t-to-w branch June 27, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancescMartiEscofetQC FrancescMartiEscofetQC FrancescMartiEscofetQC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistently use W, rather than T, in docs
2 participants
@kklein @FrancescMartiEscofetQC