Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONNX Interface #39

Merged
merged 86 commits into from
Aug 2, 2024
Merged

ONNX Interface #39

merged 86 commits into from
Aug 2, 2024

Conversation

FrancescMartiEscofetQC
Copy link
Contributor

@FrancescMartiEscofetQC FrancescMartiEscofetQC commented Jul 1, 2024

Rendered example

Checklist

  • Added a CHANGELOG.rst entry

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 90.73171% with 19 lines in your changes missing coverage. Please review.

Project coverage is 94.40%. Comparing base (3cad00e) to head (a8ecb2d).

Files Patch % Lines
metalearners/metalearner.py 78.57% 9 Missing ⚠️
metalearners/_utils.py 85.29% 5 Missing ⚠️
metalearners/slearner.py 66.66% 2 Missing ⚠️
metalearners/drlearner.py 96.29% 1 Missing ⚠️
metalearners/rlearner.py 96.42% 1 Missing ⚠️
metalearners/xlearner.py 97.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   94.90%   94.40%   -0.51%     
==========================================
  Files          15       15              
  Lines        1550     1750     +200     
==========================================
+ Hits         1471     1652     +181     
- Misses         79       98      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kklein kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

metalearners/_utils.py Outdated Show resolved Hide resolved
metalearners/_utils.py Outdated Show resolved Hide resolved
metalearners/_utils.py Outdated Show resolved Hide resolved
metalearners/_utils.py Outdated Show resolved Hide resolved
metalearners/_utils.py Outdated Show resolved Hide resolved
metalearners/_utils.py Outdated Show resolved Hide resolved
metalearners/_utils.py Outdated Show resolved Hide resolved
cbourjau
cbourjau previously approved these changes Jul 26, 2024
Copy link
Contributor

@cbourjau cbourjau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice :)

docs/examples/example_onnx.ipynb Outdated Show resolved Hide resolved
docs/examples/example_onnx.ipynb Outdated Show resolved Hide resolved
docs/examples/example_onnx.ipynb Show resolved Hide resolved
@kklein kklein merged commit b0be07c into main Aug 2, 2024
13 of 14 checks passed
@kklein kklein deleted the onnx branch August 2, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants