-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add value proposition and example to readme. #44
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 14 14
Lines 1365 1365
=======================================
Hits 1297 1297
Misses 68 68 ☔ View full report in Codecov by Sentry. |
README.md
Outdated
- Methodologically sound cross-fitting | ||
- Convenient access to and reuse of base models | ||
- Consistent APIs across Metalearners | ||
- Support for multi-class classification and more than binary treatment variants |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, multi-class only works for some metalearners, not sure if we should put it as a focus but feel free to ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes; great catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Checklist
CHANGELOG.rst
entry