Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value proposition and example to readme. #44

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

kklein
Copy link
Collaborator

@kklein kklein commented Jul 4, 2024

Checklist

  • Added a CHANGELOG.rst entry

@kklein kklein marked this pull request as ready for review July 4, 2024 12:26
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (6b33115) to head (ee6c10a).
Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files          14       14           
  Lines        1365     1365           
=======================================
  Hits         1297     1297           
  Misses         68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated
- Methodologically sound cross-fitting
- Convenient access to and reuse of base models
- Consistent APIs across Metalearners
- Support for multi-class classification and more than binary treatment variants
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, multi-class only works for some metalearners, not sure if we should put it as a focus but feel free to ignore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes; great catch!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@FrancescMartiEscofetQC FrancescMartiEscofetQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kklein kklein merged commit 274f40b into main Jul 4, 2024
15 checks passed
@kklein kklein deleted the improve-readme branch July 4, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants