Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move examples in docs to notebooks #5

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

FrancescMartiEscofetQC
Copy link
Contributor

@FrancescMartiEscofetQC FrancescMartiEscofetQC commented Jun 14, 2024

When we add the github action to build the docs we need to remember to add the step:

      - name: Check notebooks mypy # TODO: Make sure that the rest of pchs also pass
        run: |
          jupyter nbconvert --to script docs/examples/*.ipynb
          for file in docs/examples/*.txt; do mv -- "$file" "${file%.txt}.py"; done
          mypy docs/examples/*.py

Checklist

  • Added a CHANGELOG.rst entry

@FrancescMartiEscofetQC FrancescMartiEscofetQC marked this pull request as ready for review June 14, 2024 11:09
@FrancescMartiEscofetQC FrancescMartiEscofetQC merged commit 6a21bd3 into main Jun 14, 2024
6 checks passed
@FrancescMartiEscofetQC FrancescMartiEscofetQC deleted the docs_notebook branch June 14, 2024 14:56
kklein added a commit that referenced this pull request Jun 15, 2024
kklein added a commit that referenced this pull request Jun 18, 2024
* Speedup tests

Co-authored-by: Kevin Klein <[email protected]>

* Switch `strict` meaning in `validate_number_positive`

* Raise error if fitted propensity is passed through nuisance_models

* Move examples in docs to notebooks (#5)

Co-authored-by: Kevin Klein <[email protected]>

* Add space

* Add test for passing of propensity model as fitted nuisance model.

* PCH.

---------

Co-authored-by: Kevin Klein <[email protected]>
Co-authored-by: kklein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants