Fix index columns order for MetaLearnerGridSearch.results_
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 94.91% 94.94% +0.03%
==========================================
Files 15 15
Lines 1476 1485 +9
==========================================
+ Hits 1401 1410 +9
Misses 75 75 ☔ View full report in Codecov by Sentry. |
|
@FrancescMartiEscofetQC Thanks for working on this :) Would you mind adding a test case that would've failed before and won't fail anymore based on this bug fix? |
Sure! |
kklein
reviewed
Jul 10, 2024
Co-authored-by: Kevin Klein <[email protected]>
kklein
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #47
The columns order now is first
"metalearner", then all the nuisance models with their parameters and finally the treatment models with their parameters.Example
Checklist
CHANGELOG.rstentry