-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement adaptive clipping switch #59
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 94.94% 94.96% +0.02%
==========================================
Files 15 15
Lines 1485 1491 +6
==========================================
+ Hits 1410 1416 +6
Misses 75 75 ☔ View full report in Codecov by Sentry. |
Thanks for looking into this :) |
Sure, I thought of this for a while and the main reason why I chose it to be optional at initialization instead of at Seeing that both options required me to change a signature of a function which breaks the common API (if the user iterates over the metalearners and always passes the Either way I don't have a really strong opinion for either option so I am open to suggestions or other possible solutions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
Solves #52.
Checklist
CHANGELOG.rst
entry