Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split fit in fit_all_nuisance and fit_all_treatment #64

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

FrancescMartiEscofetQC
Copy link
Contributor

@FrancescMartiEscofetQC FrancescMartiEscofetQC commented Jul 19, 2024

This PR splits the fit method of each MetaLearner into fit_all_nuisance and fit_all_treatment. The goal is to make it easier for the user to "intervene" while fitting between the two steps.

Checklist

  • Added a CHANGELOG.rst entry

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 87.80488% with 5 lines in your changes missing coverage. Please review.

Project coverage is 94.85%. Comparing base (348460d) to head (e7bfa77).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
metalearners/metalearner.py 75.00% 2 Missing ⚠️
metalearners/xlearner.py 81.81% 2 Missing ⚠️
metalearners/drlearner.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   95.01%   94.85%   -0.17%     
==========================================
  Files          15       15              
  Lines        1504     1534      +30     
==========================================
+ Hits         1429     1455      +26     
- Misses         75       79       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrancescMartiEscofetQC FrancescMartiEscofetQC marked this pull request as ready for review July 19, 2024 13:38
Copy link
Collaborator

@kklein kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@FrancescMartiEscofetQC FrancescMartiEscofetQC merged commit 9406ef7 into main Jul 22, 2024
14 of 16 checks passed
@FrancescMartiEscofetQC FrancescMartiEscofetQC deleted the split_fit branch July 22, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants