Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evaluate with not None feature_set #66

Merged
merged 8 commits into from
Jul 22, 2024
Merged

Fix evaluate with not None feature_set #66

merged 8 commits into from
Jul 22, 2024

Conversation

FrancescMartiEscofetQC
Copy link
Contributor

@FrancescMartiEscofetQC FrancescMartiEscofetQC commented Jul 19, 2024 •
edited
Loading

Fixes #65

Checklist

  • Added a CHANGELOG.rst entry

@FrancescMartiEscofetQC FrancescMartiEscofetQC marked this pull request as ready for review July 19, 2024 14:12
@FrancescMartiEscofetQC FrancescMartiEscofetQC mentioned this pull request Jul 19, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jul 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (95e2cfe) to head (0865362).
Report is 26 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   95.00%   95.01%           
=======================================
  Files          15       15           
  Lines        1503     1504    +1     
=======================================
+ Hits         1428     1429    +1     
  Misses         75       75

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kklein
kklein reviewed Jul 21, 2024
View reviewed changes
Copy link
Collaborator

@kklein kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! :)

kklein
kklein approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@kklein kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@FrancescMartiEscofetQC FrancescMartiEscofetQC merged commit 348460d into main Jul 22, 2024
16 checks passed
@FrancescMartiEscofetQC FrancescMartiEscofetQC deleted the fix_65 branch July 22, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kklein kklein kklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Evaluate method fails if feature_set is not None
2 participants
@FrancescMartiEscofetQC @kklein