Adapt CI trigger to run on PR from fork. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are flaky and seem unrelated to me |
borchero
reviewed
Aug 4, 2024
.github/workflows/ci.yml
Outdated
| # We would like to trigger for CI for any pull request action - | ||
| # both from QuantCo's branches as well as forks. | ||
| pull_request: | ||
| types: [opened, labeled, unlabeled, synchronize] |
There was a problem hiding this comment.
The default types are usually sufficient (this also misses reopened ;). Since none of the jobs below seem to be dependent on labels, I don't think it's necessary to use a custom list here.
|
[Unrelated to this PR]
You might want to give https://github.com/box/flaky a try ;) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage 94.46% 94.46%
=======================================
Files 15 15
Lines 1769 1769
=======================================
Hits 1671 1671
Misses 98 98 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGELOG.rstentry