Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize evaluate #8

Merged
merged 49 commits into from
Jun 26, 2024
Merged

Parametrize evaluate #8

merged 49 commits into from
Jun 26, 2024

Conversation

FrancescMartiEscofetQC
Copy link
Contributor

@FrancescMartiEscofetQC FrancescMartiEscofetQC commented Jun 14, 2024

This PR parametrizes the evaluate method of the MetaLearner so the user can choose which metrics to use to evaluate each individual model. It also implements the method for the X and DR learners.

Checklist

  • Added a CHANGELOG.rst entry

@FrancescMartiEscofetQC FrancescMartiEscofetQC marked this pull request as ready for review June 14, 2024 12:53
Base automatically changed from fix_r_evaluate to main June 18, 2024 09:43
Copy link
Collaborator

@kklein kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly naming :)

metalearners/metalearner.py Outdated Show resolved Hide resolved
metalearners/metalearner.py Outdated Show resolved Hide resolved
metalearners/metalearner.py Outdated Show resolved Hide resolved
metalearners/metalearner.py Outdated Show resolved Hide resolved
metalearners/metalearner.py Outdated Show resolved Hide resolved
metalearners/metalearner.py Outdated Show resolved Hide resolved
metalearners/metalearner.py Outdated Show resolved Hide resolved
metalearners/metalearner.py Outdated Show resolved Hide resolved
metalearners/metalearner.py Outdated Show resolved Hide resolved
FrancescMartiEscofetQC and others added 3 commits June 24, 2024 09:14
* Centralize generation of default scoring.

* Reuse more type hints.

* Update metalearners/metalearner.py

Co-authored-by: Francesc Martí Escofet <[email protected]>

* Update metalearners/metalearner.py

Co-authored-by: Francesc Martí Escofet <[email protected]>

* Apply pchs.

---------

Co-authored-by: Francesc Martí Escofet <[email protected]>
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 98.85057% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.97%. Comparing base (3c5a3a4) to head (5fcc3ec).
Report is 2 commits behind head on main.

Current head 5fcc3ec differs from pull request most recent head c20ae75

Please upload reports for the commit c20ae75 to get more accurate results.

Files Patch % Lines
metalearners/_utils.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   94.66%   94.97%   +0.30%     
==========================================
  Files          14       14              
  Lines        1294     1352      +58     
==========================================
+ Hits         1225     1284      +59     
+ Misses         69       68       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metalearners/metalearner.py Show resolved Hide resolved
metalearners/metalearner.py Outdated Show resolved Hide resolved
metalearners/metalearner.py Outdated Show resolved Hide resolved
metalearners/tlearner.py Outdated Show resolved Hide resolved
metalearners/xlearner.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kklein kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last masks; I promise!

metalearners/drlearner.py Outdated Show resolved Hide resolved
metalearners/_utils.py Outdated Show resolved Hide resolved
@FrancescMartiEscofetQC FrancescMartiEscofetQC merged commit 2f530b2 into main Jun 26, 2024
12 checks passed
@FrancescMartiEscofetQC FrancescMartiEscofetQC deleted the parametrize_evaluate branch June 26, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants