Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to mkdocs #81

Merged
merged 102 commits into from
Feb 26, 2025
Merged

Migrate to mkdocs #81

merged 102 commits into from
Feb 26, 2025

Conversation

thomasmarwitz
Copy link
Contributor

@thomasmarwitz thomasmarwitz commented Aug 14, 2024

Demonstrate how mkdocs-jupyter plugin can be used to execute and render Jupyter Notebooks in a similar way to MyST.

Output: https://metalearners--81.org.readthedocs.build/en/81/

TODO:

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.39%. Comparing base (db0828a) to head (4f82bfe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   94.74%   94.39%   -0.35%     
==========================================
  Files          15       15              
  Lines        1807     1802       -5     
==========================================
- Hits         1712     1701      -11     
- Misses         95      101       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasmarwitz thomasmarwitz changed the title Remove sphinx specific formatting, adjust heading syntax Migrate to mkdocs Aug 21, 2024
@thomasmarwitz

This comment was marked as resolved.

@kklein

This comment was marked as outdated.

@thomasmarwitz

This comment was marked as outdated.

@kklein
Copy link
Collaborator

kklein commented Aug 27, 2024

Aside from the math and enumeration topic mentioned above, what do you see as hurdles and next steps?
Might it make sense to test whether our readthedocs setup works fine with mkdocs?

@pavelzw
Copy link
Member

pavelzw commented Aug 27, 2024

BTW an alternative to readthedocs could be github pages in combination with https://github.com/jimporter/mike. Disadvantage would be that there is no preview for PRs. Advantage would be that there is no external configuration necessary.

@kklein
Copy link
Collaborator

kklein commented Aug 27, 2024

Sounds interesting! Can we have branch-specific deployments with GitHub-pages? Given our somewhat heavy use of formulas, we rely a lot on rendered docs in PRs.

@thomasmarwitz
Copy link
Contributor Author

I don't know whether branch based deployments can be accomplished out of the box with mike and gh-pages, that would be interesting to keep an eye on.

I just tried out to host the mkdocs documentation with readthedocs and that worked: https://metalearners--81.org.readthedocs.build/en/81/

@thomasmarwitz

This comment was marked as outdated.

@thomasmarwitz

This comment was marked as resolved.

@kklein

This comment was marked as resolved.

@pavelzw

This comment was marked as resolved.

@thomasmarwitz thomasmarwitz force-pushed the mkdocs branch 2 times, most recently from 0bcbb39 to cb6c281 Compare November 26, 2024 14:31
@thomasmarwitz thomasmarwitz marked this pull request as ready for review November 29, 2024 14:47
@thomasmarwitz thomasmarwitz marked this pull request as draft November 29, 2024 14:47
@kklein

This comment was marked as resolved.

@thomasmarwitz

This comment was marked as resolved.

@thomasmarwitz

This comment was marked as resolved.

@kklein

This comment was marked as resolved.

@thomasmarwitz

This comment was marked as resolved.

@kklein
Copy link
Collaborator

kklein commented Dec 11, 2024

@thomasmarwitz sgtm :)

@thomasmarwitz thomasmarwitz force-pushed the mkdocs branch 3 times, most recently from ff0a208 to 7fbabd5 Compare December 13, 2024 09:39
@thomasmarwitz

This comment was marked as resolved.

@thomasmarwitz
Copy link
Contributor Author

@kklein, thanks for your review, I resolved or commented on everything.

Turning the private methods off was also possible :)

@kklein
Copy link
Collaborator

kklein commented Feb 26, 2025

Nice to have: if you @kklein still have the original drawio file of the transparent .svg images in docs/imgs/, could you import them with white background? Then switching to darkmode is possible without visual impairments

I added adaptations of the three svg files which should have white background in this commit: 086e3b7

Would you be so kind to give them a shot?

In case there might be further demand for adaptations, you can always import the *.drawio.svg files directly into drawio; the image files themselves contain the source. :)

pavelzw
pavelzw previously approved these changes Feb 26, 2025
Copy link
Member

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks really great, thanks a lot!

i mostly took a look on the framework and left the detailed documentation changes review to @kklein

pavelzw
pavelzw previously approved these changes Feb 26, 2025
pixi.lock Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reference: this is the diff to main (at commit 66074a3)

Dependencies

Explicit dependencies
Dependency1 Before After Change Environments
griffe-inherited-docstrings 1.1.1 Added docs
mkdocs-jupyter 0.24.8 Added docs
mkdocs-material 9.6.5 Added docs
mkdocstrings 0.28.1 Added docs
mkdocstrings-python 1.16.1 Added docs
ruff 0.9.7 Added docs
Implicit dependencies
Dependency1 Before After Change Environments
ghp-import 2.1.0 Added docs
griffe 1.5.7 Added docs
jupytext 1.16.7 Added docs
markdown 3.6 Added docs
mergedeep 1.3.4 Added docs
mkdocs 1.6.1 Added docs
mkdocs-autorefs 1.3.1 Added docs
mkdocs-get-deps 0.2.0 Added docs
mkdocs-material-extensions 1.3.1 Added docs
paginate 0.5.7 Added docs
pathspec 0.12.1 Added docs
pymdown-extensions 10.14.3 Added docs
pyyaml-env-tag 0.1 Added docs
regex 2024.11.6 Added docs
watchdog 6.0.0 Added docs

Footnotes

  1. Bold means explicit dependency. 2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pixi-diff-to-markdown, right? This is really neat!

Co-authored-by: Pavel Zwerschke <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the light mode version of these images has empty background which looks a bit nicer than this

image

@kklein could you redo this without background?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a stab at this after this PR if you don't mind :)

Copy link
Collaborator

@kklein kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks a lot!

@thomasmarwitz thomasmarwitz merged commit daeadc2 into main Feb 26, 2025
15 of 16 checks passed
@pavelzw pavelzw deleted the mkdocs branch February 26, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants