Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant benchmark condition. #85

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

kklein
Copy link
Collaborator

@kklein kklein commented Aug 15, 2024

Checklist

  • Added a CHANGELOG.rst entry

@@ -544,41 +544,34 @@ def dict_to_markdown_file(d, filename="comparison.md"):
)
print_separator()

if metalearner in {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check was redundant since the list was exhaustive.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.42%. Comparing base (b883d62) to head (6fa14fb).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   94.42%   94.42%           
=======================================
  Files          15       15           
  Lines        1793     1793           
=======================================
  Hits         1693     1693           
  Misses        100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kklein kklein marked this pull request as ready for review August 15, 2024 21:05
@kklein kklein merged commit fccde2c into main Aug 15, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant