Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MetaLearnerGridSearch #9
Implement MetaLearnerGridSearch #9
Changes from 74 commits
e8b64e6
7a11445
642cb2e
d7cef73
1234a0b
8efba91
32c721d
963debf
dc93dd1
6a4cd07
e3df56a
1a93bfa
ad71c66
1c39193
e0a9239
5094e45
f0d6f6c
a5f657d
9992576
f6c7d74
7a21186
a38ca89
0f54c2c
d6327ae
914f047
476a4ae
1c4c060
49f1556
d528045
631505e
e0e70fa
e0cd563
fc01491
0150106
6b595bd
4ac9027
9789e90
19f895c
12d41b5
4a36e25
5f0987f
d76dc74
05787f9
dc946dc
ba895a3
e81d152
9d2bbb9
c4de4f1
7fa8794
8691a02
ecfd745
6771e5a
5fcc3ec
501e5b5
99f4d4a
d06e003
d38e9d5
d4cffcb
75dd120
6401201
c20ae75
c2bda63
d4cfb2a
a14932c
003e6ce
64d2ebf
1860254
c08dd6a
7a3a82c
a98ac21
f2edc25
82d38d9
3b841e5
a7be0cd
13eeed1
0264937
bcaab55
8ad4b87
5e34a35
fa95338
bac8cfb
928edd7
83f0e78
d6c8c3f
acade9e
183b251
5a6c91f
991b2f1
29db2bb
4733b2a
669f37f
7b97173
5d1dde9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 41 in metalearners/_utils.py
Codecov / codecov/patch
metalearners/_utils.py#L37-L41
Check warning on line 65 in metalearners/grid_search.py
Codecov / codecov/patch
metalearners/grid_search.py#L65
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure about this, check this. Lmk if further sth is not clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I think I understand your point but this way of phrasing it doesn't seem perfectly obvious to me. What about
If one wants to pass optional parameters to the
MetaLearners
initialization, such asn_folds
orfeature_set
this should be done by this way, too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
669f37f
Check warning on line 197 in metalearners/grid_search.py
Codecov / codecov/patch
metalearners/grid_search.py#L197
Check warning on line 202 in metalearners/grid_search.py
Codecov / codecov/patch
metalearners/grid_search.py#L202
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid I don't quite see yet why we need/want the transformation from
{key: [value1, value2, value3]}
to[{key: value1}, {key: value2}, {key: value3}]
:/There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need it at the
__init__
so I moved this conversion to thefit
.d6c8c3f