-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling of optional arguments #13
Conversation
Codecov Report
@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 75.00% 83.92% +8.92%
==========================================
Files 1 2 +1
Lines 52 112 +60
==========================================
+ Hits 39 94 +55
- Misses 13 18 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI. that should be an error at least before 2.0, you must use things Configurations
to have the keyword struct syntax. And for web applications, it is usually to use things like Configurations
to define a schema for security reason.
also please remember to format the doc strings. For this part you have to do it manually, run JuliaFormatter in this PR before we merge things would also be a good idea. |
let's have some more tests to push the covarage above 80% at least. |
Co-authored-by: Rogerluo <[email protected]>
nice work! thanks |
closes #10, #12 & #11
This wasn't needed since multiple dispatch made things easier.
Also I had to use
@options
from IBMQClient to get around this error