Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #93 Rewrite FiniteMPS constructors #102

Conversation

lkdvos
Copy link
Member

@lkdvos lkdvos commented Dec 2, 2023

This updates the existing constructors, such that all specifications of virtual spaces are now considered to be an upper bound, instead of a fixed virtual space. This has the following advantages:

  • Users can no longer accidentally create non-full rank MPS
  • Alternating virtual space specifications can now be achieved easily with maxvspaces = repeat([V1, V2], N/2)

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c6a52bb) 84.22% compared to head (a9fc123) 84.27%.

Files Patch % Lines
src/states/finitemps.jl 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   84.22%   84.27%   +0.04%     
==========================================
  Files          63       63              
  Lines        3849     3848       -1     
==========================================
+ Hits         3242     3243       +1     
+ Misses        607      605       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkdvos lkdvos requested a review from DaanMaertens December 2, 2023 13:46
@DaanMaertens
Copy link
Collaborator

Looks good. I think it is ready to merge.

@lkdvos lkdvos merged commit 55e37cc into master Dec 4, 2023
9 of 12 checks passed
@lkdvos lkdvos deleted the 93-unable-to-construct-a-finitemps-that-has-alternating-virtual-spaces-without-specifying-all-virtual-spaces branch December 4, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to construct a FiniteMPS that has alternating virtual spaces without specifying all virtual spaces.
2 participants