Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excise RecursiveVec #95

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Excise RecursiveVec #95

merged 1 commit into from
Nov 15, 2024

Conversation

lkdvos
Copy link
Member

@lkdvos lkdvos commented Nov 14, 2024

This PR removes references to RecursiveVec to fix compatibility with the new KrylovKit.jl

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/operators/derivatives.jl 41.93% <100.00%> (ø)

... and 1 file with indirect coverage changes

@lkdvos lkdvos enabled auto-merge (squash) November 14, 2024 20:09
@lkdvos lkdvos requested a review from pbrehmer November 14, 2024 20:09
@lkdvos lkdvos merged commit f508663 into master Nov 15, 2024
27 checks passed
@pbrehmer pbrehmer deleted the ld-mpskit branch November 15, 2024 08:39
@lkdvos
Copy link
Member Author

lkdvos commented Nov 15, 2024

@pbrehmer should we already tag a version, such that at least pepskit compiles again?

@pbrehmer
Copy link
Collaborator

Yes let's do that - I think we anyway have all the features that we wanted to implement for v0.3 if I remember the road map correctly :)

@lkdvos
Copy link
Member Author

lkdvos commented Nov 15, 2024

Should I try and get the sequential thing reviewed first too?

@pbrehmer
Copy link
Collaborator

You can probably tag already since I don't have the time to work on that PR this week anymore. Also, it is mostly relevant for #91 I think, and that will take a bit to get merged anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants