Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lower bounds of dependencies and enable downgrade CI job #108

Merged
merged 15 commits into from
Feb 26, 2024

Conversation

ba2tripleO
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.11%. Comparing base (1a0b40d) to head (f217fa5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   71.11%   71.11%           
=======================================
  Files          37       37           
  Lines        1475     1475           
=======================================
  Hits         1049     1049           
  Misses        426      426           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ba2tripleO
Copy link
Member Author

This shouldn't happen: https://github.com/QuantumSavory/QuantumSavory.jl/actions/runs/8008861646/job/21876235207?pr=108#step:6:60
Since both Clifford and Savory have a lower bound set to 0.3.3 for QuantumInterface

@ba2tripleO
Copy link
Member Author

ba2tripleO commented Feb 22, 2024

Looks like its checking v0.8.0 for QuantumClifford which has lower bound set to 0.1.0 for QuantumInterface,
https://github.com/QuantumSavory/QuantumClifford.jl/blob/7da8d351320b73e3f9461fa68b65c60ec03da3ea/Project.toml#L46

so we can either lower the bound for QuantumInterface or increase the bound for QuantumClifford which is currently set to 0.8 and is currently at 0.8.19

I think there could be a lot of such adjustments to be made here for other dependencies, to make the downgrade ci pass, but it will be good to set realistic lower bounds

@Krastanov
Copy link
Member

I would suggest always going for increasing bounds, in this case increasing the one for QuantumClifford.

@Krastanov Krastanov changed the title Add Statistics to downgrade update lower bounds of dependencies and enable downgrade CI job Feb 25, 2024
@Krastanov
Copy link
Member

@Abhishek-1Bhatt , the change to Distributions's lower bound is a bit awkward -- I made it because 0.25.0 does not support newer versions of FillArrays, which I learnt by using github blame on their project.toml file. This is probably not the most elegant and efficient way to run the downstream CI job, but it is better than nothing and it is not a high priority to make it better.

@Krastanov Krastanov added the Skip-Changelog label for control of CI: skips the changelog check label Feb 25, 2024
@Krastanov Krastanov marked this pull request as ready for review February 26, 2024 02:11
@Krastanov Krastanov merged commit 2b91fc2 into QuantumSavory:master Feb 26, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog label for control of CI: skips the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants