-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update lower bounds of dependencies and enable downgrade CI job #108
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
=======================================
Coverage 71.11% 71.11%
=======================================
Files 37 37
Lines 1475 1475
=======================================
Hits 1049 1049
Misses 426 426 ☔ View full report in Codecov by Sentry. |
This shouldn't happen: https://github.com/QuantumSavory/QuantumSavory.jl/actions/runs/8008861646/job/21876235207?pr=108#step:6:60 |
Looks like its checking so we can either lower the bound for QuantumInterface or increase the bound for QuantumClifford which is currently set to I think there could be a lot of such adjustments to be made here for other dependencies, to make the downgrade ci pass, but it will be good to set realistic lower bounds |
I would suggest always going for increasing bounds, in this case increasing the one for QuantumClifford. |
@Abhishek-1Bhatt , the change to Distributions's lower bound is a bit awkward -- I made it because 0.25.0 does not support newer versions of FillArrays, which I learnt by using github blame on their project.toml file. This is probably not the most elegant and efficient way to run the downstream CI job, but it is better than nothing and it is not a high priority to make it better. |
No description provided.