Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for QuantumSymbolics to 0.4, (keep existing compat) #144

Merged
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ QuantumClifford = "0.9.9"
QuantumInterface = "0.3.5"
QuantumOptics = "1.1.0"
QuantumOpticsBase = "0.5.3"
QuantumSymbolics = "0.3"
QuantumSymbolics = "0.4.3"
Random = "1"
Reexport = "1.2.2"
ResumableFunctions = "0.6.9"
Expand Down
2 changes: 1 addition & 1 deletion ext/QuantumSavoryMakie/QuantumSavoryMakie.jl
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@
## the colors and locations for various observables
if !isnothing(rn[:observables][])
for (O, rsidx, links) in rn[:observables][]
val = real(observable(tuple((network[rs...] for rs in rsidx)...), O, NaN))
val = real(observable(tuple((network[rs...] for rs in rsidx)...), O; something=NaN))

Check warning on line 153 in ext/QuantumSavoryMakie/QuantumSavoryMakie.jl

View check run for this annotation

Codecov / codecov/patch

ext/QuantumSavoryMakie/QuantumSavoryMakie.jl#L153

Added line #L153 was not covered by tests
# TODO issue a warning if val has (percentage-wise) significant imaginary component (here, for plotting, when we implicitly are taking the real part)
for (iʳᵉᵍ, iˢˡᵒᵗ) in rsidx
xˢ = registercoords[iʳᵉᵍ][1]
Expand Down
2 changes: 1 addition & 1 deletion src/StatesZoo/StatesZoo.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module StatesZoo

using DocStringExtensions
using QuantumSymbolics, QuantumOpticsBase
using QuantumSymbolics: withmetadata, @withmetadata, Metadata
using QuantumSymbolics: @withmetadata, Metadata
import QuantumSymbolics: express_nolookup

import LinearAlgebra
Expand Down
6 changes: 6 additions & 0 deletions test/test_aqua.jl
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
using Aqua
using QuantumSavory

if get(ENV,"JET_TEST","")=="true"
# JET generates new methods with ambiguities
else

@test Test.detect_ambiguities(QuantumSavory) == Tuple{Method, Method}[]

Aqua.test_all(QuantumSavory,
Expand All @@ -10,3 +14,5 @@ Aqua.test_all(QuantumSavory,
)

@test length(Aqua.Piracy.hunt(QuantumSavory)) == 6

end
Loading