Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix observable call due to something being now a keyword #145

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Fix observable call due to something being now a keyword #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/QuantumSavoryMakie/QuantumSavoryMakie.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@
## the colors and locations for various observables
if !isnothing(rn[:observables][])
for (O, rsidx, links) in rn[:observables][]
val = real(observable(tuple((network[rs...] for rs in rsidx)...), O, NaN))
val = real(observable(tuple((network[rs...] for rs in rsidx)...), O; something=NaN))

Check warning on line 153 in ext/QuantumSavoryMakie/QuantumSavoryMakie.jl

View check run for this annotation

Codecov / codecov/patch

ext/QuantumSavoryMakie/QuantumSavoryMakie.jl#L153 

Added line #L153 was not covered by tests
# TODO issue a warning if val has (percentage-wise) significant imaginary component (here, for plotting, when we implicitly are taking the real part)
for (iʳᵉᵍ, iˢˡᵒᵗ) in rsidx
xˢ = registercoords[iʳᵉᵍ][1]
Expand Down
Loading