Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid method-override warnings in tests by using separate modules #177

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

Krastanov
Copy link
Member

By splitting the example tests in separate modules (each @testitem creates its own module) now we have separate namespaces and no worries about overwriting of methods.

I also removed a few other sources of spurious messages.

Lastly, I reorganized how the setup and tear-down for OpenGL plotting tests happens, hopefully leading to fewer crashes in buildkite.

@Krastanov
Copy link
Member Author

Let's see if the CI passes. If that is the case, could you do a quick review and merge if there is nothing worrisome, @hanakl ?

@Krastanov Krastanov added the Skip-Changelog label for control of CI: skips the changelog check label Jan 18, 2025
Copy link
Contributor

Benchmark Result

Judge result

Benchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jl

Job Properties

  • Time of benchmarks:
  • Target: 18 Jan 2025 - 16:32
  • Baseline: 18 Jan 2025 - 16:33
  • Package commits:
  • Target: e5602d
  • Baseline: b1c8f5
  • Julia commits:
  • Target: 4976d0
  • Baseline: 4976d0
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["tagquery", "register", "queryall"] 0.99 (5%) 0.95 (1%) ✅

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["register", "creation_and_initialization"]
  • ["tagquery", "messagebuffer"]
  • ["tagquery", "misc"]
  • ["tagquery", "register"]

Julia versioninfo

Target

Julia Version 1.10.7
Commit 4976d05258e (2024-11-26 15:57 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 24.04.1 LTS
 uname: Linux 6.8.0-1017-azure #20-Ubuntu SMP Tue Oct 22 03:43:13 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3243 MHz 4227 s 0 s 299 s 2314 s 0 s
 #2 3241 MHz 4062 s 0 s 288 s 2460 s 0 s
 #3 3241 MHz 4127 s 0 s 264 s 2459 s 0 s
 #4 3243 MHz 4026 s 0 s 270 s 2555 s 0 s
 Memory: 15.615272521972656 GB (13636.29296875 MB free)
 Uptime: 692.96 sec
 Load Avg: 1.19 2.56 1.73
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline

Julia Version 1.10.7
Commit 4976d05258e (2024-11-26 15:57 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 24.04.1 LTS
 uname: Linux 6.8.0-1017-azure #20-Ubuntu SMP Tue Oct 22 03:43:13 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3241 MHz 4415 s 0 s 309 s 2746 s 0 s
 #2 3235 MHz 4372 s 0 s 307 s 2761 s 0 s
 #3 3242 MHz 4228 s 0 s 277 s 2975 s 0 s
 #4 3243 MHz 4027 s 0 s 278 s 3176 s 0 s
 Memory: 15.615272521972656 GB (13615.4453125 MB free)
 Uptime: 756.06 sec
 Load Avg: 1.06 2.25 1.68
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Target result

Benchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jl

Job Properties

  • Time of benchmark: 18 Jan 2025 - 16:32
  • Package commit: e5602d
  • Julia commit: 4976d0
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["register", "creation_and_initialization", "from_tests"] 208.358 μs (5%) 983.23 KiB (1%) 2552
["tagquery", "messagebuffer", "query"] 284.817 ns (5%) 64 bytes (1%) 2
["tagquery", "messagebuffer", "querydelete"] 2.154 μs (5%) 96 bytes (1%) 3
["tagquery", "misc", "from_tests"] 10.900 μs (5%) 26.44 KiB (1%) 233
["tagquery", "register", "query"] 3.460 s (5%) 2.024 s 521.14 MiB (1%) 4945623
["tagquery", "register", "queryall"] 3.699 s (5%) 2.142 s 1.61 GiB (1%) 4564121

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["register", "creation_and_initialization"]
  • ["tagquery", "messagebuffer"]
  • ["tagquery", "misc"]
  • ["tagquery", "register"]

Julia versioninfo

Julia Version 1.10.7
Commit 4976d05258e (2024-11-26 15:57 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 24.04.1 LTS
 uname: Linux 6.8.0-1017-azure #20-Ubuntu SMP Tue Oct 22 03:43:13 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3243 MHz 4227 s 0 s 299 s 2314 s 0 s
 #2 3241 MHz 4062 s 0 s 288 s 2460 s 0 s
 #3 3241 MHz 4127 s 0 s 264 s 2459 s 0 s
 #4 3243 MHz 4026 s 0 s 270 s 2555 s 0 s
 Memory: 15.615272521972656 GB (13636.29296875 MB free)
 Uptime: 692.96 sec
 Load Avg: 1.19 2.56 1.73
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline result

Benchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jl

Job Properties

  • Time of benchmark: 18 Jan 2025 - 16:33
  • Package commit: b1c8f5
  • Julia commit: 4976d0
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["register", "creation_and_initialization", "from_tests"] 205.223 μs (5%) 983.23 KiB (1%) 2552
["tagquery", "messagebuffer", "query"] 298.360 ns (5%) 64 bytes (1%) 2
["tagquery", "messagebuffer", "querydelete"] 2.124 μs (5%) 96 bytes (1%) 3
["tagquery", "misc", "from_tests"] 10.440 μs (5%) 26.44 KiB (1%) 233
["tagquery", "register", "query"] 3.417 s (5%) 2.006 s 523.28 MiB (1%) 4965623
["tagquery", "register", "queryall"] 3.743 s (5%) 2.109 s 1.70 GiB (1%) 4804211

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["register", "creation_and_initialization"]
  • ["tagquery", "messagebuffer"]
  • ["tagquery", "misc"]
  • ["tagquery", "register"]

Julia versioninfo

Julia Version 1.10.7
Commit 4976d05258e (2024-11-26 15:57 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 24.04.1 LTS
 uname: Linux 6.8.0-1017-azure #20-Ubuntu SMP Tue Oct 22 03:43:13 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3241 MHz 4415 s 0 s 309 s 2746 s 0 s
 #2 3235 MHz 4372 s 0 s 307 s 2761 s 0 s
 #3 3242 MHz 4228 s 0 s 277 s 2975 s 0 s
 #4 3243 MHz 4027 s 0 s 278 s 3176 s 0 s
 Memory: 15.615272521972656 GB (13615.4453125 MB free)
 Uptime: 756.06 sec
 Load Avg: 1.06 2.25 1.68
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() lbt
Sys.CPU_THREADS 4

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 48 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 4
On-line CPU(s) list: 0-3
Vendor ID: AuthenticAMD
Model name: AMD EPYC 7763 64-Core Processor
CPU family: 25
Model: 1
Thread(s) per core: 2
Core(s) per socket: 2
Socket(s): 1
Stepping: 1
BogoMIPS: 4890.86
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves user_shstk clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization: AMD-V
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 1 MiB (2 instances)
L3 cache: 32 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Vulnerable: Safe RET, no microcode
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines; STIBP disabled; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected

Cpu Property Value
Brand AMD EPYC 7763 64-Core Processor
Vendor :AMD
Architecture :Unknown
Model Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores 16 physical cores, 16 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 512, 32768) kbytes
64 byte cache line size
Address Size 48 bits virtual, 48 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.09%. Comparing base (b1c8f5e) to head (dedd537).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   68.09%   68.09%           
=======================================
  Files          42       42           
  Lines        1730     1730           
=======================================
  Hits         1178     1178           
  Misses        552      552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanakl hanakl merged commit 97c9e4d into master Jan 24, 2025
17 of 19 checks passed
@hanakl hanakl deleted the neatertests branch January 24, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog label for control of CI: skips the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants