Apply suggestions from code review

Co-authored-by: Mozi <[email protected]>
QuasarApp · May 3, 2021 · e86858a · e86858a
1 parent 6559129
commit e86858a
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/Deploy/Distributions/idistribution.cpp b/Deploy/Distributions/idistribution.cpp
@@ -252,7 +252,7 @@ bool iDistribution::deployIcon(TemplateInfo &info, const DistroModule& pkg) {
         info.Icon = releativeLocation(pkg) + "/icons/" + iconInfo.fileName();
         if (!copyFile(icon, localData + "/icons/", false)) {
 
-            QuasarAppUtils::Params::log(QString("Failed to copy icon: %0. %1").arg(icon),
+            QuasarAppUtils::Params::log(QString("Failed to copy icon: %0.").arg(icon),
                                         QuasarAppUtils::Error);
 
             return false;
@@ -279,4 +279,3 @@ QString iDistribution::releativeLocation(const DistroModule &module) const {
 
 }
 
-
diff --git a/Deploy/configparser.cpp b/Deploy/configparser.cpp
@@ -629,7 +629,7 @@ void ConfigParser::packagesErrorLog(const QString &option) {
 bool ConfigParser::parseDeployMode() {
 
     if (QuasarAppUtils::Params::isEndable("deploySystem-with-libc")) {
-        QuasarAppUtils::Params::log("You use a deprecated option \"deploySystem-with-libc\"."
+        QuasarAppUtils::Params::log("You are using a deprecated option \"deploySystem-with-libc\"."
                                     " In this version this option is no different from \"deploySystem\"."
                                     " Please use the deploySystem option.", QuasarAppUtils::Warning);
         QuasarAppUtils::Params::setEnable("deploySystem", true );

diff --git a/Deploy/metafilemanager.cpp b/Deploy/metafilemanager.cpp
@@ -254,7 +254,7 @@ void MetaFileManager::createRunMetaFiles(const QHash<QString, DeployCore::QtModu
     for (auto i = DeployCore::_config->targets().cbegin(); i != DeployCore::_config->targets().cend(); ++i) {
 
         if (!createRunScript(i.key())) {
-            QuasarAppUtils::Params::log("Fail to created the run script!",
+            QuasarAppUtils::Params::log("Failed to create a run script: " + i.key(),
                                          QuasarAppUtils::Error);
         }
 

diff --git a/Deploy/packing.cpp b/Deploy/packing.cpp
@@ -55,7 +55,7 @@ bool Packing::create() {
         }
 
         if (!package->deployTemplate(*this)) {
-            QuasarAppUtils::Params::log(QString("Deploy package template error occured. Package: %0.").
+            QuasarAppUtils::Params::log(QString("Failed to deploy a package template. Package: %0.").
                                         arg(package->getClassName()),
                                         QuasarAppUtils::Error);
             return false;
@@ -255,4 +255,3 @@ void Packing::handleOutputUpdate() {
         QuasarAppUtils::Params::log(erroutLog,
                                     QuasarAppUtils::Info);
 }
-