Add free-form text to qube for notes, comments, ... #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
- Coverage 75.26% 75.21% -0.05%
==========================================
Files 52 52
Lines 8975 8983 +8
==========================================
+ Hits 6755 6757 +2
- Misses 2220 2226 +6 ☔ View full report in Codecov by Sentry. |
alimirjamali
force-pushed
the
issue-899
branch
2 times, most recently
from
fa3aa90 to
dbce8cc
Compare
qubesadmin part of adding free-form text to each qube for comments, notes, descriptions, remarks, reminders, etc. fixes: QubesOS/qubes-issues#899
alimirjamali
force-pushed
the
issue-899
branch
from
dbce8cc to
dc029b3
Compare
marmarek
requested changes
Feb 27, 2025
| ''' Get qube notes ''' | ||
| try: | ||
| response = self.qubesd_call(self._method_dest, 'admin.vm.notes.Get') | ||
| except Exception as exc: |
There was a problem hiding this comment.
This is definitely too broad. If anything, maybe just qubesadmin.exc.QubesDaemonNoResponseError, but even that I'm not sure. qubesd should return already correct exception on error.
| try: | ||
| self.qubesd_call(self._method_dest, 'admin.vm.notes.Set', \ | ||
| payload = str(notes).encode('ascii')) | ||
| except Exception as exc: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qubesadmin part of adding free-form text to each qube for comments, notes, descriptions, remarks, reminders, etc.
fixes: QubesOS/qubes-issues#899