-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipewire: adjust buffer parameters #200
Conversation
Allow more than one buffer (to allow application / daemon preparing next buffer when previous one is being processed). And also adjust buffer size based on other pipewire modules. QubesOS/qubes-issues#8415
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023102904-4.2&flavor=pull-requests New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023071104-4.2&flavor=update
Failed tests7 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/77326#dependencies 23 fixed
Unstable tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
SPA_PARAM_BUFFERS_blocks, SPA_POD_Int(1), | ||
SPA_PARAM_BUFFERS_size, SPA_POD_Int(2048), | ||
SPA_PARAM_BUFFERS_size, SPA_POD_Int(2048 * (int)impl->frame_size), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to worry about this overflowing? I presume not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, frame_size is always 4 with the current format (and very small number with any other format, if we'd change).
Allow more than one buffer (to allow application / daemon preparing next
buffer when previous one is being processed). And also adjust buffer
size based on other pipewire modules.
QubesOS/qubes-issues#8415