Refactor+qt5 19 #1024
Closed
Refactor+qt5 19 #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On Tue, Dec 15, 2020 at 03:02:25AM -0800, Patarimi wrote:
The last path of pkg-config is not correct. I just add `/mingw%MBITS%` and now Qt5 is correctly linked.
You can view, comment on, or merge this pull request online at:
merged. I haven't ever touched .appveyor.yml, I'm happy if you look
after it.
|
|
And I'm happy if it was helpful. :) |
|
On Tue, Dec 15, 2020 at 05:47:13AM -0800, Patarimi wrote:
And I'm happy if it was helpful. :)
According to github, you closed it instead of merging it. Is it normal ?
I merged, and the ticket was still open, so I closed it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure where I should merge this. I was trying to work on #1020, but the build is not working on windows (Qt5 not found). I think I fix it.
The last path of pkg-config is not correct. I just add
/mingw%MBITS%and now Qt5 is correctly linked.