Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A/B and E2E testing #1040

Merged
merged 8 commits into from
Nov 27, 2024
Merged

A/B and E2E testing #1040

merged 8 commits into from
Nov 27, 2024

Conversation

nablaone
Copy link
Member

@nablaone nablaone commented Nov 25, 2024 •
edited
Loading

This PR adds an E2E test. Search queries are A/B tested against Elasticsearch.

3 queries fail. They are skipped now and will added as unit tests.

@nablaone nablaone changed the title [WIP] A/B and E2E testing A/B and E2E testing Nov 26, 2024
@nablaone nablaone marked this pull request as ready for review November 26, 2024 15:05
@nablaone nablaone requested a review from a team as a code owner November 26, 2024 15:05
@nablaone nablaone mentioned this pull request Nov 27, 2024
Draft
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 27, 2024 •
edited
Loading

Deploying quesma with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7b476c7
Status: ✅  Deploy successful!
Preview URL: https://62918407.quesma.pages.dev
Branch Preview URL: https://pr-ab-e2e.quesma.pages.dev

View logs

avelanarius
avelanarius approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@avelanarius avelanarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 comment could be improved

nablaone and others added 2 commits November 27, 2024 19:21
@nablaone @avelanarius
Update ci/it/testcases/test_ab.go
8d9ab42 
Co-authored-by: Piotr Grabowski <[email protected]>
Signed-off-by: Rafał Strzaliński <[email protected]>
@nablaone @avelanarius
Update ci/it/testcases/test_ab.go
1e5ac5f 
Co-authored-by: Piotr Grabowski <[email protected]>
Signed-off-by: Rafał Strzaliński <[email protected]>
@nablaone nablaone added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 73218ff Nov 27, 2024
5 checks passed
@nablaone nablaone deleted the pr-ab-e2e branch November 27, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avelanarius avelanarius avelanarius approved these changes

@jakozaur jakozaur Awaiting requested review from jakozaur jakozaur is a code owner automatically assigned from QuesmaOrg/engineering

@mieciu mieciu Awaiting requested review from mieciu mieciu is a code owner automatically assigned from QuesmaOrg/engineering

@trzysiek trzysiek Awaiting requested review from trzysiek trzysiek is a code owner automatically assigned from QuesmaOrg/engineering

@pdelewski pdelewski Awaiting requested review from pdelewski pdelewski is a code owner automatically assigned from QuesmaOrg/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nablaone @avelanarius