Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-vpr-yosys-yosys-plugins #386

Open
wants to merge 401 commits into
base: master
Choose a base branch
from
Open

Conversation

kkumar23
Copy link

update to latest version

kkumar23 and others added 30 commits May 7, 2021 03:47
…erilog file written by VPR

Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: samycharas <[email protected]>
skip, as the golden does not match
Fixing up post-layout Verilog netlist from VPR
…ed for post layout simulation

Signed-off-by: Maciej Kurc <[email protected]>
Cell models for behavioral simulations
kkumar23 and others added 20 commits June 14, 2021 11:35
Fixed command-line option file lookup
Bumps [third_party/qlf-fasm](https://github.com/QuickLogic-Corp/ql_fasm) from `e19d804` to `e5d0915`.
- [Release notes](https://github.com/QuickLogic-Corp/ql_fasm/releases)
- [Commits](QuickLogic-Corp/ql_fasm@e19d804...e5d0915)

---
updated-dependencies:
- dependency-name: third_party/qlf-fasm
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
…ird_party/qlf-fasm-e5d0915

Bump third_party/qlf-fasm from `e19d804` to `e5d0915`
Updating CLK naming convention. Now it starts from bottom as CLK0 and…
add clk constraint
adding a version
update with latest tools
update to latest version
@kkumar23 kkumar23 requested a review from mkurc-ant June 25, 2021 05:46
@kkumar23
Copy link
Author

@mkurc-ant : Can we always use latest version of vtr/yosys/yosys-plugins instead of specifying the versions?

@mkurc-ant
Copy link

@kkumar23 You can do that by removing the version string from conda package specification strings. However I advice against it as sometimes update to a newer version may break things (as it probably happened now - the CI is red). That's why in my opinion it is better to keep all the versions fixed and update them manually only when needed.

@kkumar23
Copy link
Author

@mkurc-ant : Right, the reason i asked is when there are any commit in vpr/yosys-plugins we need to make sure the environment.yml needs manual update. Sometimes we may miss that, which happened recently so.
Again the question would be how often should we update the package in yml file. And is it by trail and error that we need to pick the right version ?

@mkurc-ant
Copy link

@kkumar23 The environment.yml should contain fixed package version with which the code in the repository will work. This is also being checked by CI. There is also the second file under quicklogic/common/toolchain_wrappers that holds versions to be used by the toolchain. Those versions should be the same.

I don't think that we have missed any update to environment.yml in this repository as the CI on the master branch is green.

I can see two situations where we need to change package versions:

    1. A new feature / bugfix has been added to a package and it is required to run the code,
    1. We want to keep package versions in sync with another fork (eg. upstream),

The first one is obvious however for the second it is usually that the packages at upstream are older than those in this fork so that we take care to update them and make sure that everything works when upstreaming.

I wouldn't call updating versions trial and error. Usually we use the most recent revisions (unless there is something preventing from that eg. a breaking change) and plan for additional effort required to test and update the rest of the code to match.

@kkumar23
Copy link
Author

I agree that right solution to this would be to use the upstream. But since we are using Quicklogic fork for all activities, I think we need to make sure packages should be updated in case if there are any PR to VPR or Yosys/plugins.

@mkurc-ant
Copy link

@kkumar23 Yes, If you want the QuickLogic for to always use the newest tool versions then this is ok.

But then you will eventually want to integrate the fork with upstream SymbiFlow where different versions may be used and the solution would be to update the versions in upstream as well. This may break other architectures of different vendors.

Anyways, the CI is red because the versions you updated in environment.yaml are not compatible with the rest of the code/scripts. Do you want us to work on fixing the CI issue so that those versions can be used in the QuickLogic fork?

@kkumar23
Copy link
Author

@tpagarani can comment on the support to fix CI for latest vtr/yosys package support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants