-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update-vpr-yosys-yosys-plugins #386
base: master
Are you sure you want to change the base?
Conversation
…erilog file written by VPR Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: Maciej Kurc <[email protected]>
…d toolchain Signed-off-by: Maciej Kurc <[email protected]>
…ript Signed-off-by: Maciej Kurc <[email protected]>
add testcases
Signed-off-by: samycharas <[email protected]>
Signed-off-by: samycharas <[email protected]>
Signed-off-by: samycharas <[email protected]>
skip, as the golden does not match
Signed-off-by: samycharas <[email protected]>
Signed-off-by: samycharas <[email protected]>
Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: samycharas <[email protected]>
Signed-off-by: samycharas <[email protected]>
Fixing up post-layout Verilog netlist from VPR
adding feature specific testcases
…ed floating. Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: Maciej Kurc <[email protected]>
…led up Signed-off-by: samycharas <[email protected]>
…ed for post layout simulation Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: Maciej Kurc <[email protected]>
Add support for k6n10 device
Cell models for behavioral simulations
Fixed command-line option file lookup
Bumps [third_party/qlf-fasm](https://github.com/QuickLogic-Corp/ql_fasm) from `e19d804` to `e5d0915`. - [Release notes](https://github.com/QuickLogic-Corp/ql_fasm/releases) - [Commits](QuickLogic-Corp/ql_fasm@e19d804...e5d0915) --- updated-dependencies: - dependency-name: third_party/qlf-fasm dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
skip_failing_testcase
…ird_party/qlf-fasm-e5d0915 Bump third_party/qlf-fasm from `e19d804` to `e5d0915`
Updating CLK naming convention. Now it starts from bottom as CLK0 and…
enable dsp tcs
correct the spell
add clk constraint
Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: Maciej Kurc <[email protected]>
adding a version
K4N8 default bitstream support
update with latest tools
update to latest version
@mkurc-ant : Can we always use latest version of vtr/yosys/yosys-plugins instead of specifying the versions? |
@kkumar23 You can do that by removing the version string from conda package specification strings. However I advice against it as sometimes update to a newer version may break things (as it probably happened now - the CI is red). That's why in my opinion it is better to keep all the versions fixed and update them manually only when needed. |
@mkurc-ant : Right, the reason i asked is when there are any commit in vpr/yosys-plugins we need to make sure the environment.yml needs manual update. Sometimes we may miss that, which happened recently so. |
@kkumar23 The I don't think that we have missed any update to I can see two situations where we need to change package versions:
The first one is obvious however for the second it is usually that the packages at upstream are older than those in this fork so that we take care to update them and make sure that everything works when upstreaming. I wouldn't call updating versions trial and error. Usually we use the most recent revisions (unless there is something preventing from that eg. a breaking change) and plan for additional effort required to test and update the rest of the code to match. |
I agree that right solution to this would be to use the upstream. But since we are using Quicklogic fork for all activities, I think we need to make sure packages should be updated in case if there are any PR to VPR or Yosys/plugins. |
@kkumar23 Yes, If you want the QuickLogic for to always use the newest tool versions then this is ok. But then you will eventually want to integrate the fork with upstream SymbiFlow where different versions may be used and the solution would be to update the versions in upstream as well. This may break other architectures of different vendors. Anyways, the CI is red because the versions you updated in |
@tpagarani can comment on the support to fix CI for latest vtr/yosys package support. |
update to latest version